search

PDAL / python

PDAL's Python Support
Other
117 stars 35 forks source link

cmake Development.Module #117

Closed drewgilliam closed 2 years ago

drewgilliam commented 2 years ago

cmake 3.18.0+ offers the sub-components Development.Module and Development.Embed to limit necessary development artifacts. Require only Development.Module if that option is available. https://cmake.org/cmake/help/latest/module/FindPython3.html?highlight=Development.Module

Development.Embed artifacts (i.e., libpython.so) should not be necessary, as PDAL python bindings do not appear to be embedding python in the application.

This lets users build the PDAL python bindings from source in environments such as a manylinux container, which by design does not include libpython.so files.

drewgilliam commented 2 years ago

It looks like an admin might have added this commit directly to master (@hobu?), so this PR can be closed?