search

PDAL / python

PDAL's Python Support
Other
116 stars 34 forks source link

Expose `Pipeline._get_json()` as pubic method #123

Closed danleesmith closed 1 year ago

danleesmith commented 2 years ago

Filing ticket as per @hobu's Gitter request.

The Pipeline._get_json() method is useful for writing out JSON pipeline strings from constructed pipelines and should be a made public.

Proposal: In ./pdal/pipeline.py change

def _get_json(self) -> str:
        ...

to

def get_json(self) -> str:
        ...
hobu commented 2 years ago

I would propose we would alias ._get_json to toJSON to follow conventions and make it clear that you're getting a serialization back.