PDAL / python

PDAL's Python Support
Other
116 stars 34 forks source link

Windows test failing silently #95

Closed gsakkis closed 2 years ago

gsakkis commented 2 years ago

Just found out that the Windows CI tests have been silently failing for some time now, for example on master or on the pythonic_api PR. Moving py.test to the end reveals the failure. Apparently only the last command status code is returned, any previous failures are ignored.

By the way, the specific failure seems to be a minor bug in PDAL core:

E         -  'pipeline': [{'filename': 'test/data/1.2-with-color.las',
E         ?                                      ^
E         +  'pipeline': [{'filename': 'test/data\\1.2-with-color.las',
E         ?                                      ^^

The path in the input JSON is test/data/1.2-with-color.las and is serialized as test/data\1.2-with-color.las.

abellgithub commented 2 years ago

I don't understand what test is failing or why.

gsakkis commented 2 years ago

Let's ignore the specific test for now, I can work around it or open a new issue on PDAL. The CI issue is that exit 1; exit 0; (or whatever is the equivalent command is on Windows) succeeds.

gsakkis commented 2 years ago

Fixed in https://github.com/PDAL/python/commit/afd56ead91932fe284386152de41b63df12568bc