search

PG85 / OpenTerrainGenerator

Minecraft Terrain Generator for Bukkit/Spigot/Forge
MIT License
199 stars 82 forks source link

Bug: Invalid settings cause crashes without warning instead of falling back to defaults and/or logging errors. #470

Closed aaronhowser1 closed 3 years ago

aaronhowser1 commented 4 years ago

OTG Plugin or Mod

[Please specify if it's about Forge Mod or Spigot server Plugin placing "x" into []]

OTG Version

[Please specify the full OTG version that you are running by placing "x" into []]

Forge or Spigot Versions

14.23.5.2847

What other plugins are you running?

AdvancedRocketry-1.12.2-1.7.0-209-universal.jar                       
aether_legacy-1.12.2-v1.4.4.jar                                       
AkashicTome-1.2-12.jar                                                
AppleSkin-mc1.12-1.0.9.jar                                            
appliedenergistics2-rv6-stable-7.jar                                  
AutoRegLib-1.3-32.jar                                                 
Baubles-1.12-1.5.2.jar                                                
BetterFps-1.4.8.jar                                                   
Biome_Bundle-1.12.2-v6.1.jar                                          
BloodMagic-1.12.2-2.4.3-105.jar                                       
Botania r1.10-363.jar                                                 
BuildingGadgets-2.8.3.jar                                             
Chameleon-1.12-4.1.3.jar                                              
Charm-1.12.2-1.3.7.jar                                                
Chisel-MC1.12.2-1.0.2.45.jar                                          
chiselsandbits-14.33.jar                                              
CodeChickenLib-1.12.2-3.2.3.358-universal.jar                         
CoFHCore-1.12.2-4.6.6.1-universal.jar                                 
CoFHWorld-1.12.2-1.4.0.1-universal.jar                                
CommonCapabilities-1.12.2-2.4.6.jar                                   
Controlling-3.0.9.jar                                                 
CraftPresence-1.12.2-1.6.1.jar                                        
CraftTweaker2-1.12-4.1.20.562.jar                                     
CTM-MC1.12.2-1.0.2.31.jar                                             
CyclopsCore-1.12.2-1.6.3.jar                                          
DefaultOptions_1.12.2-9.2.8.jar                                       
EnderCore-1.12.2-0.5.73.jar                                           
EnderIO-1.12.2-5.1.55.jar                                             
EnderIO-endergy-1.12.2-5.1.55.jar                                     
EnderStorage-1.12.2-2.4.6.137-universal.jar                           
environmentaltech-1.12.2-2.0.20.1.jar                                 
extrautils2-1.12-1.9.9.jar                                            
FancyBlockParticles-1.12.x-2.4.1.jar                                  
FastFurnace-1.12.2-1.3.1.jar                                          
FastWorkbench-1.12.2-1.7.3.jar                                        
foamfix-0.10.10-1.12.2.jar                                            
forestry_1.12.2-5.8.2.387.jar                                         
Forgelin-1.8.4.jar                                                    
ForgeMultipart-1.12.2-2.6.2.83-universal.jar                          
FTBBackups-1.1.0.1.jar                                                
FTBLib-5.4.7.0.jar                                                    
FTBQuests-1.8.0.237.jar                                               
FTBUltimine_1.12-1.2.1.jar                                            
FTBUtilities-5.4.0.124.jar                                            
Guide-API-1.12-2.1.8-63.jar                                           
ImmersiveEngineering-0.12-92.jar                                      
immersivepetroleum-1.12.2-1.1.9.jar                                   
industrialcraft-2-2.8.197-ex112.jar                                   
IntegratedCrafting-1.12.2-1.0.9.jar                                   
IntegratedDynamics-1.12.2-1.1.5.jar                                   
IntegratedTerminals-1.12.2-1.0.13.jar                                 
IntegratedTunnels-1.12.2-1.6.11.jar                                   
InventoryTweaks-1.63.jar                                              
ItemFilters-1.0.3.12.jar                                              
jeibees-0.9.0.5-mc1.12.2.jar                                          
jei_1.12.2-4.15.0.291.jar                                             
jetif-1.12.2-1.5.1.jar                                                
journeymap-1.12.2-5.7.1.jar                                           
JustEnoughResources-1.12.2-0.9.2.60.jar                               
KubeJS-forge-1.12.2-1.1.0.63.jar                                      
letsencryptcraft-1.10.2-1.2.0.jar                                     
LibVulpes-1.12.2-0.4.2-74-universal.jar                               
llibrary-1.7.19-1.12.2.jar                                            
logisticspipes-0.10.2.218.jar                                         
MagicBees-1.12.2-3.1.10.jar                                           
mcjtylib-1.12-3.5.4.jar                                               
Mekanism-1.12.2-9.8.3.390.jar                                         
MekanismGenerators-1.12.2-9.8.3.390.jar                               
MekanismTools-1.12.2-9.8.3.390.jar                                    
minetogether-1.10.2-2.2.1.jar                                         
modnametooltip_1.12.2-1.10.1.jar                                      
moreoverlays-1.15.1-mc1.12.2.jar                                      
MouseTweaks-2.10-mc1.12.2.jar                                         
MrTJPCore-1.12.2-2.1.4.43-universal.jar                               
NaturesCompass-1.12.2-1.8.5.jar                                       
NetherPortalFix_1.12.1-5.3.17.jar                                     
NuclearCraft-2o.1.2-1.12.2.jar                                        
OpenTerrainGenerator-1.12.2 - v8.3.jar                                
Patchouli-1.0-20.jar                                                  
phosphor-1.12.2-0.2.6+build50-universal.jar                           
Placebo-1.12.2-1.6.0.jar                                              
pneumaticcraft-repressurized-1.12.2-0.11.14-395.jar                   
prefab-1.3.0.26.jar                                                   
ProjectRed-1.12.2-4.9.4.120-Base.jar                                  
ProjectRed-1.12.2-4.9.4.120-integration.jar                           
ProjectRed-1.12.2-4.9.4.120-lighting.jar                              
Quark-r1.6-179.jar                                                    
QuarkOddities-1.12.2.jar                                              
QuickLeafDecay-MC1.12.1-1.2.4.jar                                     
rats-3.2.9.jar                                                        
RedstoneFlux-1.12-2.1.1.1-universal.jar                               
ResourceLoader-MC1.12.1-1.5.3.jar                                     
ResourceReloader-1.0.2.5.jar                                          
rftools-1.12-7.73.jar                                                 
rftoolsdim-1.12-5.71.jar                                              
SmoothFont-mc1.12.2-2.1.1.jar                                         
StorageDrawers-1.12.2-5.4.1.jar                                       
test.txt                                                              
Thaumcraft-1.12.2-6.1.BETA26.jar                                      
ThaumicInventoryScanning_1.12.2-2.0.10.jar                            
ThaumicJEI-1.12.2-1.6.0-27.jar                                        
theoneprobe-1.12-1.4.28.jar                                           
ThermalFoundation-1.12.2-2.6.7.1-universal.jar                        
TipTheScales-1.12.2-1.0.4.jar                                         
TombManyGraves-1.12-4.2.0.jar                                         
unloader-1.2.0.jar                                                    
valkyrielib-1.12.2-2.0.20.1.jar                                       
VanillaFix-1.0.10-150.jar                                             
Vanilla_Vistas 1.1.jar                                                
xnet-1.12-1.8.2.jar                                                   
zerocore-1.12.2-0.1.2.8.jar

Description

I was going to type .03, but it crashed when I typed the .. I guess that makes sense since it didn't start with a 0, but it should probably just give an error message in the window instead of crashing. https://paste.dimdev.org/urigigowoy.mccrash

PG85 commented 4 years ago

Thanks for reporting this, unfortunately there are a lot of settings that need to be fool-proofed this way, putting this in backlog for now.

PG85 commented 3 years ago

Have fixed logging and exceptions for 0.0.14, and have cleaned up as much as possible for the rest. We'll need to keep an eye on any configuration errors that cause crashes and improve logging/exceptions as we go along.