PIFSCstockassessments / 2024-WCNPO-MLS-Rebuilding

1 stars 0 forks source link

Add option in Build_Input_File to calculate time averages of catch, catch weight at age and selectivity at age by unique fleet #9

Open JonBrodziak opened 10 months ago

michellesculley commented 9 months ago

@JonBrodziak I'm updating the SS_to_AgePRO file to allow for these calculations. Currently, the total catch by fleet is calculated in the function to be the proportion of catch by fleet in the last year. Would you prefer the proportion of catch by fleet in each year or just output the catch by fleet in each year and do any additional manipulations in the Build_Input_File?

JonBrodziak commented 9 months ago

It would be preferable to output the catch by fleet in each year. Then set up the manipulations in the Build_Input_File, e.g. one default might be to output a 3-year weighted average.

On Wed, Jan 3, 2024 at 11:27 AM Michelle Sculley @.***> wrote:

@JonBrodziak https://github.com/JonBrodziak I'm updating the SS_to_AgePRO file to allow for these calculations. Currently, the total catch by fleet is calculated in the function to be the proportion of catch by fleet in the last year. Would you prefer the proportion of catch by fleet in each year or just output the catch by fleet in each year and do any additional manipulations in the Build_Input_File?

— Reply to this email directly, view it on GitHub https://github.com/PIFSCstockassessments/2024-WCNPO-MLS-Rebuilding/issues/9#issuecomment-1875994562, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVXIZTJNXMWEIEQFKYHITLYMXEM7AVCNFSM6AAAAABBAL6ZZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVHE4TINJWGI . You are receiving this because you were mentioned.Message ID: <PIFSCstockassessments/2024-WCNPO-MLS-Rebuilding/issues/9/1875994562@ github.com>

-- Jon Brodziak, Ph.D. NOAA Inouye Regional Center Pacific Islands Fisheries Science Center 1845 Wasp Boulevard, Building 176, NMFS/PIFSC/FRMD Mail Room 2247 Honolulu, Hawaii 96818 USA PIFSC Stock Asessment Program https://pifscstockassessments.github.io/ Phone: 808-725-5617 Email: @.***

“Wherever my travels may lead, paradise is where I am.” ~ Voltaire

The views expressed in this message are my own and do not necessarily reflect any position of NOAA.

michellesculley commented 9 months ago

I have tested the functionality of the SS_to_AgePro function for the annual models, it all seems to work properly. I have updated the 013_BuildAGEPROInputfile to allow for fishery selectivity at age, catch at age, and total catch to be calculated across a set of years. I also added the functionality to pull the F by fleet and average it across years to replicated F status quo type of projections. Some work is done for the quarterly time step, but I am still testing that code.

JonBrodziak commented 9 months ago

I am in the process of converting from the previous code used in Build_Input_File.R and its variants. Will probably have the changes made in a few days and will push these to the branch Meg made to handle the changes using version control. In general, it will be good to move towards using the branch feature to make future code changes and merge them into the main/origin branch.

michellesculley commented 9 months ago

I have tested both the Build_input_file and the 013_BuildAGEPROInput.R files and they seem to run well, produces an input file that runs in AGEPRO just fine. The issue with the Fishery selectivity at age inputs are fixed, and the calculation of the correct catch by proportion catch is fixed.