search

PSLmodels / OG-USA

Overlapping-generations macroeconomic model for evaluating fiscal policy in the United States
https://pslmodels.github.io/OG-USA/
Creative Commons Zero v1.0 Universal
19 stars 34 forks source link

Remove `rpy2` dependency #115

Closed jdebacker closed 3 months ago

jdebacker commented 3 months ago

This PR removes the rpy2 dependency by replacing the .RData files with zipped CSV files.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.51%. Comparing base (e994433) to head (d7ee0fb).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/115/graphs/tree.svg?width=650&height=150&src=pr&token=XOLXIKEL86&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels)](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) ```diff @@ Coverage Diff @@ ## master #115 +/- ## =========================================== - Coverage 73.15% 46.51% -26.65% =========================================== Files 11 17 +6 Lines 868 1363 +495 =========================================== - Hits 635 634 -1 - Misses 233 729 +496 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/115/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/115/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `46.51% <100.00%> (-26.65%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/115?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [ogusa/\_\_init\_\_.py](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/115?src=pr&el=tree&filepath=ogusa%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#diff-b2d1c2EvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [ogusa/psid\_data\_setup.py](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/115?src=pr&el=tree&filepath=ogusa%2Fpsid_data_setup.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#diff-b2d1c2EvcHNpZF9kYXRhX3NldHVwLnB5) | `98.78% <100.00%> (-0.08%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/115/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels)
jdebacker commented 3 months ago

@rickecon This PR is ready for review.

rickecon commented 3 months ago

@jdebacker. This PR is ready to merge. I restarted the CI and saw all the tests pass. I committed one change to the CHANGELOG.md file, which made all the tests re-run. I will merge this PR as soon as all the test run again. But I saw the Windows tests work. This PR successfully puts the Windows tests back in. Nice fix.