search

PSLmodels / OG-USA

Overlapping-generations macroeconomic model for evaluating fiscal policy in the United States
https://pslmodels.github.io/OG-USA/
Creative Commons Zero v1.0 Universal
19 stars 34 forks source link

Update GitHub Actions and package deployment #74

Closed rickecon closed 8 months ago

rickecon commented 8 months ago

This PR:

cc: @jdebacker

rickecon commented 8 months ago

@jdebacker. This PR is spinning out because we need to first merge in PR #73, which fixes the treatment of rho and surv_rate.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d6aaba5) 73.76% compared to head (ed5c028) 73.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #74 +/- ## ======================================= Coverage 73.76% 73.76% ======================================= Files 24 24 Lines 1616 1616 ======================================= Hits 1192 1192 Misses 424 424 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/74/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/74/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `73.76% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [cs-config/cs\_config/functions.py](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#diff-Y3MtY29uZmlnL2NzX2NvbmZpZy9mdW5jdGlvbnMucHk=) | `19.66% <0.00%> (ø)` | | | [setup.py](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rickecon commented 8 months ago

@jdebacker. I think this PR is ready for your review and subsequent merge if you think it is ready. It is still not passing the two Windows GH Action CI tests (those tests aren't even starting). This is similar to the previous PR and is an issue we need to resolve. But I think we can merge this in if you think it is ready.

jdebacker commented 8 months ago

@rickecon These are some great additions here! Everything looks good to me and I'm merging. Looking forward to seeing ogusa on PyPI.