search

PSLmodels / OG-USA

Overlapping-generations macroeconomic model for evaluating fiscal policy in the United States
https://pslmodels.github.io/OG-USA/
Creative Commons Zero v1.0 Universal
19 stars 34 forks source link

Updated classifiers in setup.py #75

Closed rickecon closed 11 months ago

rickecon commented 11 months ago

This PR updates the classifiers in setup.py. This is important because the previous classifier of 'License :: OSI Approved :: CC0 1.0 Universal public domain dedication' was not valid and was breaking our publish_to_pypi.yml GitHub Action.

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Invalid value for classifiers. Error: Classifier 'License :: OSI       
         Approved :: CC0 1.0 Universal public domain dedication' is not a valid 
         classifier.

This change should fix the issue. But the only way to test whether it works is to merge the PR.

@jdebacker. Will you please merge this PR as soon as all the tests (or 4 of the 6 tests) pass? Thanks.

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6e42207) 73.76% compared to head (8200d1f) 73.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #75 +/- ## ======================================= Coverage 73.76% 73.76% ======================================= Files 24 24 Lines 1616 1616 ======================================= Hits 1192 1192 Misses 424 424 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/75/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/75/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `73.76% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [setup.py](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#diff-c2V0dXAucHk=) | `0.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rickecon commented 11 months ago

@jdebacker. I think this PR is ready. The last two tests (Windows, Python 3.9 and 3.10) are just stalled at the test stage.