search

PSLmodels / OG-USA

Overlapping-generations macroeconomic model for evaluating fiscal policy in the United States
https://pslmodels.github.io/OG-USA/
Creative Commons Zero v1.0 Universal
19 stars 34 forks source link

pct_change specifies fill_method='pad' #82

Closed talumbau closed 5 months ago

talumbau commented 5 months ago
codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9da4947) 73.76% compared to head (a3a16a2) 73.76%.

:exclamation: Current head a3a16a2 differs from pull request most recent head e03c79a. Consider uploading reports for the commit e03c79a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #82 +/- ## ======================================= Coverage 73.76% 73.76% ======================================= Files 24 24 Lines 1616 1616 ======================================= Hits 1192 1192 Misses 424 424 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/82/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/82/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `73.76% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

talumbau commented 5 months ago

@rickecon @jdebacker I noticed that the linting check is failing on files I didn't change. I like black as a formatter (good choice!). Do you want me to submit a PR that gets linting passing again? I saw this deprecation warning when running the example and thought it would be a good way to kick the tires. Let me know what makes sense.

jdebacker commented 5 months ago

@talumbau I appreciate you opening another PR to fix the formatting. We use black with the 79 character line option. If you upgrade to the most recent black version and run black -l 79 ./ from the OG-USA directory, this should resolve the linting failures.

rickecon commented 5 months ago

@talumbau. Yes. We just merged a PR into OG-Core (PR #898) that set the black requirement in environment.yml to black>=24.1.1. We found that black version 23 formatted differently. We also might need to restrict the Python version in OG-USA to be <3.12.

rickecon commented 5 months ago

@talumbau @jdebacker. The change in this PR has been added to PR #89, along with another line in the macro_params.py module that required a similar update. I am closing this PR.