search

PSLmodels / OG-USA

Overlapping-generations macroeconomic model for evaluating fiscal policy in the United States
https://pslmodels.github.io/OG-USA/
Creative Commons Zero v1.0 Universal
19 stars 34 forks source link

Updates to environment.yml and macro_params.py #89

Closed rickecon closed 7 months ago

rickecon commented 7 months ago

This PR:

This PR includes the change suggested by @talumbau in PR #82. However, that PR was running too many tests and was having black formatting issues. So I have closed that PR and added its changes to this PR.

cc: @jdebacker

rickecon commented 7 months ago

@jdebacker. I am trying out adding back the Windows tests in build_and_test.yml in this PR to see if the problem in Issue #78. If these tests continue to fail or get stuck in the GH Action, I will pull them out.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7a6757b) 70.82% compared to head (cef2e94) 70.82%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #89 +/- ## ======================================= Coverage 70.82% 70.82% ======================================= Files 22 22 Lines 1340 1340 ======================================= Hits 949 949 Misses 391 391 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/89/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/89/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `70.82% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rickecon commented 7 months ago

@jdebacker. This PR is ready for your review.

jdebacker commented 7 months ago

LGTM - thanks @rickecon! Merging.