Closed rickecon closed 3 months ago
@jdebacker. These three test failures in the last three tests of the test_get_micro_data.py
Linux Python 3.9 tests seem like legitimate failures.
tests/test_get_micro_data.py ........FFF
I tried adding the windows-latest
OS tests back into build_and_test.yml
, but I got the same error as noted in Issue #78. I am removing the Windows OS tests again from build_and_test.yml
.
Run pytest -m 'not local and not regression' --cov=./ --cov-report=xml
pytest -m 'not local and not regression' --cov=./ --cov-report=xml
shell: C:\Program Files\Git\bin\bash.EXE -l {0}
env:
INPUT_RUN_POST: true
CONDA: C:\Users\runneradmin\miniconda[3](https://github.com/PSLmodels/OG-USA/actions/runs/8643695604/job/23698134190?pr=99#step:5:3)
CONDA_PKGS_DIR: C:\Users\runneradmin\conda_pkgs_dir
C:\Users\runneradmin\miniconda3\envs\ogusa-dev\lib\site-packages\pep8.py:110: FutureWarning: Possible nested set at position 1
EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.70%. Comparing base (
9f1d02f
) to head (415df86
).
LGTM, thanks @rickecon! Ready for this to be merged?
@jdebacker. Let me do one last check of a couple things. I still have this white whale of trying to get the Windows tests working again.
@jdebacker. This PR is ready for your final review. I have made all the changes I am going to make. I spent hours trying to get the windows-latest
tests added back in. But I got everything else in. All these tests should pass by 5pm ET.
@jdebacker. All tests passed locally on my machine.
(ogusa-dev) richardevans@Richards-MacBook-Pro-2 OG-USA % pytest
======================= test session starts =========================
platform darwin -- Python 3.11.8, pytest-8.1.1, pluggy-1.4.0
rootdir: /Users/richardevans/Docs/Economics/OSE/OG-USA
configfile: pytest.ini
testpaths: ./tests
plugins: cov-5.0.0, xdist-3.5.0
collected 37 items
tests/test_calibrate.py .... [ 10%]
tests/test_get_micro_data.py .............. [ 48%]
tests/test_income.py ............ [ 81%]
tests/test_psid_data_setup.py ... [ 89%]
tests/test_run_example.py . [ 91%]
tests/test_utils.py . [ 94%]
tests/test_wealth.py .. [100%]
========== 37 passed, 111 warnings in 767.83s (0:12:47) ==================
This PR:
build_and_test.yml
so that those tests only run when one of those files is changed.deploy_docs.yml
anddocs_check.yml
, and limitsdocs_check.yml
to only run on pull requests.tax_functions.md
in order to test if the event triggers worked properly (yes, they worked)environment.yml
./tests/test_io_data/
file that used output from the taxcalc package. This package was recently updated. I also changed thetest_get_data()
test in thetest_get_micro_data.py
file because the new taxcalc data included four years instead of two years. In order to conserve repo memory footprint, we deleted the last two years of the output.cc: @jdebacker