search

PSLmodels / blog

PSL blog using Fastpages.
http://blog.pslmodels.org
2 stars 6 forks source link

Added Day 5 demo day OG-USA blog post and image #32

Closed rickecon closed 3 years ago

rickecon commented 3 years ago

This PR adds the Day 5 Demo Day blog post for the "How to Use OG-USA" demo day (Jan. 11, 2021). Thanks @MaxGhenis for the help. I do have some questions.

  1. In the blog post, I add the OG-USA logo image (OG-USA_logo_long.png) at the top using the command ![](https://pslmodels.org/imgs/OG-USA_logo_long.png). However, I don't have access to the pslmodels.org/imgs/ folder. So I just placed that image in the images folder in the blogs repository. Does the GitHub action automatically add new images to the pslmodels.org/imgs/ folder?
  2. Why is there a one-space indent for much of the text of the post? Is that important for the fastpages formatting? If not, I recommend no indent.
MaxGhenis commented 3 years ago

Thanks @rickecon, I made a few edits in https://github.com/rickecon/blog/pull/1 addressing these and others. Below is a screenshot of the beginning of the post after running make server locally. If the edits look good, I can merge this PR after you merge my PR.

  • In the blog post, I add the OG-USA logo image (OG-USA_logo_long.png) at the top using the command ![](https://pslmodels.org/imgs/OG-USA_logo_long.png). However, I don't have access to the pslmodels.org/imgs/ folder. So I just placed that image in the images folder in the blogs repository. Does the GitHub action automatically add new images to the pslmodels.org/imgs/ folder?

I couldn't see any pslmodels.org/imgs folder on the web or in the GitHub organizations, but local paths work too, so I pointed to the file you added to the images folder in this PR.

  • Why is there a one-space indent for much of the text of the post? Is that important for the fastpages formatting? If not, I recommend no indent.

I see that prior posts had this, and I'm not sure why. For mine, I didn't add spaces, just used VSCode. The leading spaces were breaking the headings in your post, so I removed them.

image

rickecon commented 3 years ago

OK @MaxGhenis. I merged in your changes to my branch, I added some small updates to the blog post text, and I added .DS_Store to the .gitignore because I saw that come up in my git status. This is ready to go as soon as all the checks pass.

MaxGhenis commented 3 years ago

The image is no longer in the PR, so it's not loading. The new_post.md also shouldn't be deleted. Could you add these back? (Sorry if I did something wrong in my PR to make them show up.)

rickecon commented 3 years ago

@MaxGhenis. Added the logo back. Give me two minutes to add new_post.md back.

rickecon commented 3 years ago

@MaxGhenis. There. Everything should be in order now.