search

PSMRI / HWC-UI-ARCHIVED

UI module for Health and Wellness centre (HWC) application. HWC is one of the applications of AMRIT designed to capture details of service packages as per guidelines which should be available at a Health and Wellness centre.
GNU General Public License v3.0
0 stars 18 forks source link

Confusing build process #66

Open drtechie opened 1 year ago

drtechie commented 1 year ago

The war file generation is not documented properly or the packages added to the project are confusing.

  1. The package.json script has "war" script that generates the build and runs a grunt task. The grunt task however results in an error.
> HWC-UI@1.0.2 grunt /Users/drtechie/Dev/PSMRI/HWC-UI
> grunt

Running "war:target" (war) task
Warning: Unexpected token * Use --force to continue.

Aborted due to warnings.
npm ERR! code ELIFECYCLE
npm ERR! errno 3
npm ERR! HWC-UI@1.0.2 grunt: `grunt`
npm ERR! Exit status 3
npm ERR! 
npm ERR! Failed at the HWC-UI@1.0.2 grunt script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
  1. GitHub Actions have one workflow file that packages the war file with mvn.

Questions

  1. Is the packaging done with grunt or mvn package?
  2. The GitHub workflow and pom.xml has many references to TMUI for this repo (HWC-UI).
  3. The pom.xml file has several references to internal IPs.
  4. There are at least 2 additional workflows present under .github folder which do not have the right .yml extension. Are these really used? Can we clean it up?
ravishanigarapu commented 1 year ago

++Ancy

Get Outlook for Androidhttps://aka.ms/AAb9ysg

Internal - General Use

From: Mithun James @.> Sent: Monday, October 9, 2023 11:00:29 AM To: PSMRI/HWC-UI @.> Cc: Ravi Shanigarapu @.>; Assign @.> Subject: [PSMRI/HWC-UI] Confusing build process (Issue #66)

CAUTION:This email is received from an external domain. Open the hyperlink(s) & attachment(s) with caution. .

The war file generation is not documented properly or the packages added to the project are confusing.

  1. The package.json script has "war" script that generates the build and runs a grunt task. The grunt task however results in an error.

  2. GitHub Actions have one workflow file that packages the war file with mvn.

Questions

  1. Is the packaging done with grunt or mvn package?
  2. The GitHub workflow and pom.xml has many references to TMUI for this repo (HWC-UI).
  3. The pom.xml file has several references to internal IPs.
  4. There are at least 2 additional workflows present under .github folder which do not have the right .yml extension. Are these really used? Can we clean it up?

— Reply to this email directly, view it on GitHubhttps://github.com/PSMRI/HWC-UI/issues/66, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7YKFKFG5T7V24NS27EOSLTX6ODXLAVCNFSM6AAAAAA5YH5OVKVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTEMZTGI4DINA. You are receiving this because you were assigned.Message ID: @.***>

'The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com'

ravishanigarapu commented 1 year ago

Hi Mithun,

We have addressed to the questions which is issue in build. We will send a document regarding the war file generation for the UI project.

Questions

  1. Is the packaging done with grunt or mvn package? - We are using maven package in this project.
  2. The GitHub workflow and pom.xml has many references to TMUI for this repo (HWC-UI) - We have made HWC UI from TM UI, that's why we have references of TM UI. It's not a duplicate one but we are using the same API's for both and in HWC UI we have added new visit categories and other features.
  3. The pom.xml file has several references to internal IPs. - The IP's used in the pom.xml is for the internal purpose for the offshore to run the project. Those are offshore IP's.
  4. There are at least 2 additional workflows present under .github folder which do not have the right .yml extension. Are these really used? Can we clean it up? - They are both .yml extension files, sast.yml is used for static analysis using code QL and package.yml is used for packaging war files. These are both being used currently in the project. Thanks and Regards, Ancy Riju.

Internal - General Use From: Ravi Shanigarapu @.> Sent: Tuesday, October 10, 2023 10:33 AM To: PSMRI/HWC-UI @.>; PSMRI/HWC-UI @.> Cc: Assign @.>; Ancy Riju @.***> Subject: Re: [PSMRI/HWC-UI] Confusing build process (Issue #66)

++Ancy

Get Outlook for Androidhttps://aka.ms/AAb9ysg

Internal - General Use

From: Mithun James @.**@.>> Sent: Monday, October 9, 2023 11:00:29 AM To: PSMRI/HWC-UI @.**@.>> Cc: Ravi Shanigarapu @.**@.>>; Assign @.**@.>> Subject: [PSMRI/HWC-UI] Confusing build process (Issue #66)

CAUTION:This email is received from an external domain. Open the hyperlink(s) & attachment(s) with caution. .

The war file generation is not documented properly or the packages added to the project are confusing.

  1. The package.json script has "war" script that generates the build and runs a grunt task. The grunt task however results in an error.
  2. GitHub Actions have one workflow file that packages the war file with mvn.

Questions

  1. Is the packaging done with grunt or mvn package?
  2. The GitHub workflow and pom.xml has many references to TMUI for this repo (HWC-UI).
  3. The pom.xml file has several references to internal IPs.
  4. There are at least 2 additional workflows present under .github folder which do not have the right .yml extension. Are these really used? Can we clean it up?

- Reply to this email directly, view it on GitHubhttps://github.com/PSMRI/HWC-UI/issues/66, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7YKFKFG5T7V24NS27EOSLTX6ODXLAVCNFSM6AAAAAA5YH5OVKVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTEMZTGI4DINA. You are receiving this because you were assigned.Message ID: @.**@.>>

'The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com'

drtechie commented 1 year ago

  1. In that case let's remove references to grunt. It's not required and adds unnecessary complexity.

  2. I get that HWC-UI was made from TM-UI. But that doesn't mean the artifactId and all the references of build generation should still be TM-UI. It must be cleaned up.

  3. This isn't helping either. dev hostnames and ports must be configurable for any developer so that they can set it up in local machine. Since this is a UI repo and Maven is only used to war generation, let's clean this up for building.

  4. There are 4 files in the folder. 2 of them don't have .yml extension. Are they used?

ravishanigarapu commented 1 year ago

Replied to the GitHub issue. https://github.com/PSMRI/HWC-UI/issues/66 [https://opengraph.githubassets.com/7fd22daa89008946831414d5d8161a787bae4c5b8cb08b8d222d2b3706779212/PSMRI/HWC-UI/issues/66]https://github.com/PSMRI/HWC-UI/issues/66 Confusing build process · Issue #66 · PSMRI/HWC-UIhttps://github.com/PSMRI/HWC-UI/issues/66 The war file generation is not documented properly or the packages added to the project are confusing. The package.json script has "war" script that generates the build and runs a grunt task. The g... github.com

From: Ancy Riju @.> Sent: Tuesday, October 10, 2023 10:57 AM To: Ravi Shanigarapu @.>; Dr Mithun James @.>; PSMRI/HWC-UI @.>; PSMRI/HWC-UI @.>; Puneet Kumar Bhatia @.>; Harimohan Rajamohanan @.>; Anjana K J @.>; Gadamsetti Siva Krishna Pavan @.> Cc: Assign @.>; Shashank Kharkwal @.>; Syed Saleem @.>; Vijay Kumar Nuthalpati @.***> Subject: RE: [PSMRI/HWC-UI] Confusing build process (Issue #66)

Hi Mithun,

We have addressed to the questions which is issue in build. We will send a document regarding the war file generation for the UI project.

Questions

  1. Is the packaging done with grunt or mvn package? – We are using maven package in this project.
  2. The GitHub workflow and pom.xml has many references to TMUI for this repo (HWC-UI) - We have made HWC UI from TM UI, that’s why we have references of TM UI. It’s not a duplicate one but we are using the same API’s for both and in HWC UI we have added new visit categories and other features.
  3. The pom.xml file has several references to internal IPs. – The IP’s used in the pom.xml is for the internal purpose for the offshore to run the project. Those are offshore IP’s.
  4. There are at least 2 additional workflows present under .github folder which do not have the right .yml extension. Are these really used? Can we clean it up? – They are both .yml extension files, sast.yml is used for static analysis using code QL and package.yml is used for packaging war files. These are both being used currently in the project.

Thanks and Regards,

Ancy Riju.

Internal - General Use

From: Ravi Shanigarapu @.> Sent: Tuesday, October 10, 2023 10:33 AM To: PSMRI/HWC-UI @.>; PSMRI/HWC-UI @.> Cc: Assign @.>; Ancy Riju @.***> Subject: Re: [PSMRI/HWC-UI] Confusing build process (Issue #66)

++Ancy

Get Outlook for Androidhttps://aka.ms/AAb9ysg

Internal - General Use

From: Mithun James @.**@.>> Sent: Monday, October 9, 2023 11:00:29 AM To: PSMRI/HWC-UI @.**@.>> Cc: Ravi Shanigarapu @.**@.>>; Assign @.**@.>> Subject: [PSMRI/HWC-UI] Confusing build process (Issue #66)

CAUTION:This email is received from an external domain. Open the hyperlink(s) & attachment(s) with caution. .

The war file generation is not documented properly or the packages added to the project are confusing.

  1. The package.json script has "war" script that generates the build and runs a grunt task. The grunt task however results in an error.
  2. GitHub Actions have one workflow file that packages the war file with mvn.

Questions

  1. Is the packaging done with grunt or mvn package?
  2. The GitHub workflow and pom.xml has many references to TMUI for this repo (HWC-UI).
  3. The pom.xml file has several references to internal IPs.
  4. There are at least 2 additional workflows present under .github folder which do not have the right .yml extension. Are these really used? Can we clean it up?

— Reply to this email directly, view it on GitHubhttps://github.com/PSMRI/HWC-UI/issues/66, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7YKFKFG5T7V24NS27EOSLTX6ODXLAVCNFSM6AAAAAA5YH5OVKVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTEMZTGI4DINA. You are receiving this because you were assigned.Message ID: @.**@.>>

'The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com'

drtechie commented 1 year ago

Actions:

I will:

  1. Remove grunt.
  2. Remove references to internal IPs.
  3. Clean up the build process with maven.