search

Pacific-salmon-assess / MetricsCOSEWIC

R Package for calculating COSEWIC metrics. Initial focus is on Probability of Decline.
GNU General Public License v3.0
0 stars 2 forks source link

Minor typo in testing script #67

Closed carrieholt closed 2 years ago

carrieholt commented 2 years ago

The du.df input for this function is a two column dataframe, not three column dataframe (which test.data currently is) https://github.com/SOLV-Code/MetricsCOSEWIC/blob/94d05ffe62475b0a77a61a2eb8e1b360e1d88c48/TestingScripts/DEV_BugReport_Num61%2662.R#L54-L61

I suggest revising line 55 to: du.df = test.data %>% select(Year, Abd),

Note, we do need the 3 column test.data for a function further down in the code; this simple fix here for this function should work.

SOLV-Code commented 2 years ago

thank you, please implement as you work through

carrieholt commented 2 years ago

Merged.