Fix Github raw links - Githubissues

Pamasich / kbin-kes

Add-on manager and scripting framework for kbin

MIT License

0 stars 0 forks source link

Fix Github raw links #44

Closed Pamasich closed 8 months ago

Pamasich commented 9 months ago

Sometimes Github returns the wrong page when using its /raw/ links. Switch them to using raw.githubusercontent.com instead to prevent this.

Further discussed in aclist/kbin-kes:#205.

Pamasich commented 8 months ago

Currently planned goals:

Replace the github raw links with direct links to raw.githubusercontent.com
Read up on whether there's any reason NOT to do this

Then:

Close this issue if no good reason not to do this was found.
Otherwise bring it up on the main repository and keep this issue unchanged

aclist commented 8 months ago

I think eventually this is going to bump into the rate limit if the number of mods exceeds about 80 (currently at about half that). Maybe we should be thinking about keeping atomic scripts as files-of-reference in the source code and accepting atomic scripts for PRs, but having a build routine that consolidates all of them into a single JS file from which the functions can be sourced at runtime. (At this point, functions would absolutely have to be private to each mod to prevent collisions, and any mods not following this would need to be refactored. Or some sort of mod function namespacing logic could be used.) This would effectively shrink the requires from N==mods to 1, plus a handful of files like the CSS.

Pamasich commented 8 months ago

Hmm, good argument. I'll remove it from the items I planned to do next then. Seems like there's still more planning to do with this one.

Pamasich commented 8 months ago

The requires-approval tag means that any future steps on this should be discussed first, I put it on non-minor changes to others' mods or KES in general.

Just for clarification since the name isn't too clear.

Pamasich commented 8 months ago

Actually, I'm not sure what I was thinking just now. I'll put it back to Planned.

Halfway through your comment I seem to have forgotten that this won't be a problem until KES gets some more mods and runs into the rate limit, so it's absolutely possible to change the links for now and worry about that after changing them, not instead of.

Pamasich commented 8 months ago

I should adjust the goals though.

Currently planned goals:

Replace the github raw links with direct links to raw.githubusercontent.com
Read up on whether there's any reason NOT to do this
Create a new issue on the future problem that has been brought up here, both here and on the main repository

Then:

Close this issue if no good reason not to do this was found.
Otherwise bring it up on the main repository and keep this issue unchanged

Pamasich commented 8 months ago

So, I've switched all the urls over and created the pull request for it. Couldn't really find any reason not to do it online, both using search engines and AI, so I assume it's safe.

Will create the new issues tomorrow. This one will be closed when the pull request is merged.