Rewrite fix-codeblocks and alt-all-content-access to use a namespace function

Pamasich / kbin-kes

Add-on manager and scripting framework for kbin

MIT License

0 stars 0 forks source link

Rewrite fix-codeblocks and alt-all-content-access to use a namespace function #66

Closed Pamasich closed 8 months ago

Pamasich commented 8 months ago

To prevent name conflicts, KES is now moving to enforce that every mod must have its functions defined inside the entrypoint function. My mods should be updated accordingly.

Currently planned goals:

Refactor the fix-codeblocks mod to follow the pattern of fix-pagination-arrows
Refactor the alt-all-content-access mod to follow the pattern of fix-pagination-arrows

Then:

Close this issue

Pamasich commented 8 months ago

Actually don't close it. This will break my existing tests, so the issue should remain open to remind me to fix them.

Pamasich commented 8 months ago

The fix-codeblocks refactor is done, but wasn't necessary in the first place.

Pamasich commented 8 months ago

Not for now at least, it would have been if I added new features. But the version currently in KES is already encapsulated.

Pamasich commented 8 months ago

Basically keeping this open now just to remind me to rewrite the tests.

Pamasich commented 8 months ago

Actually, there's another issue for that.