Panakotta00 / FicsIt-Networks

Control, Monitor, Manage and Automate your Satisfactory.
https://ficsit.app/mod/FicsItNetworks
GNU General Public License v3.0
156 stars 51 forks source link

[Crash] Simple coroutines seem to crash the host (Possibily multiplayer issue) #198

Closed TheGreyDiamond closed 1 year ago

TheGreyDiamond commented 2 years ago

Describe the bug I tried using this https://www.tutorialspoint.com/lua/lua_coroutines.htm example and it seems to work a little. After some time while the code is running the host just crashes.

Here are two crash reports we could capture:

Version: 176027, IsEditor: No, IsPerforceBuild: No, BuildConfiguration: Shipping, Launcher: Steam, NetMode: Listen Server, IsUsingMods: Yes

Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0xffffffffffffffff

FactoryGame_FicsItNetworks_Win64_Shipping!luaD_call() [G:\Projects\eris\src\ldo.c:507]
FactoryGame_FicsItNetworks_Win64_Shipping!luaD_rawrunprotected() [G:\Projects\eris\src\ldo.c:146]
FactoryGame_FicsItNetworks_Win64_Shipping!lua_resume() [G:\Projects\eris\src\ldo.c:680]
FactoryGame_FicsItNetworks_Win64_Shipping!luaResume() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\FicsItKernel\Processor\Lua\LuaProcessor.cpp:773]
FactoryGame_FicsItNetworks_Win64_Shipping!luaD_call() [G:\Projects\eris\src\ldo.c:483]
FactoryGame_FicsItNetworks_Win64_Shipping!luaV_execute() [G:\Projects\eris\src\lvm.c:1615]
FactoryGame_FicsItNetworks_Win64_Shipping!resume() [G:\Projects\eris\src\ldo.c:646]
FactoryGame_FicsItNetworks_Win64_Shipping!luaD_rawrunprotected() [G:\Projects\eris\src\ldo.c:146]
FactoryGame_FicsItNetworks_Win64_Shipping!lua_resume() [G:\Projects\eris\src\ldo.c:680]
FactoryGame_FicsItNetworks_Win64_Shipping!UFINLuaProcessor::LuaTick() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\FicsItKernel\Processor\Lua\LuaProcessor.cpp:561]
FactoryGame_FicsItNetworks_Win64_Shipping!FFINLuaProcessorTick::syncTick() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\FicsItKernel\Processor\Lua\LuaProcessor.cpp:169]
FactoryGame_FicsItNetworks_Win64_Shipping!UFINKernelSystem::Tick() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\FicsItKernel\FicsItKernel.cpp:123]
FactoryGame_FicsItNetworks_Win64_Shipping!AFINComputerCase::Factory_Tick() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\Computer\FINComputerCase.cpp:146]
FactoryGame_FactoryGame_Win64_Shipping!<lambda_9a1b75034c50804c2f23014618340d68>::operator()() [D:\ws\SB-211116092526-440\UE4\Games\FactoryGame\Source\FactoryGame\Private\FGBuildableSubsystem.cpp:532]
FactoryGame_FactoryGame_Win64_Shipping!ParallelForImpl::ParallelForInternal<TFunctionRef<void __cdecl(int)> >() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Core\Public\Async\ParallelFor.h:227]
FactoryGame_FactoryGame_Win64_Shipping!AFGBuildableSubsystem::TickFactoryActors() [D:\ws\SB-211116092526-440\UE4\Games\FactoryGame\Source\FactoryGame\Private\FGBuildableSubsystem.cpp:547]
FactoryGame_FactoryGame_Win64_Shipping!AFGBuildableSubsystem::TickFactory() [D:\ws\SB-211116092526-440\UE4\Games\FactoryGame\Source\FactoryGame\Private\FGBuildableSubsystem.cpp:475]
FactoryGame_FactoryGame_Win64_Shipping!FFactoryTickFunction::ExecuteTick() [D:\ws\SB-211116092526-440\UE4\Games\FactoryGame\Source\FactoryGame\Private\FactoryTick.cpp:110]
FactoryGame_Engine_Win64_Shipping!FTickFunctionTask::DoTask() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Engine\Private\TickTaskManager.cpp:289]
FactoryGame_Engine_Win64_Shipping!TGraphTask<FTickFunctionTask>::ExecuteTask() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Core\Public\Async\TaskGraphInterfaces.h:891]
FactoryGame_Core_Win64_Shipping!FNamedTaskThread::ProcessTasksUntilIdle() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Core\Private\Async\TaskGraph.cpp:611]
FactoryGame_Engine_Win64_Shipping!FTickTaskSequencer::ReleaseTickGroup() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Engine\Private\TickTaskManager.cpp:585]
FactoryGame_Engine_Win64_Shipping!FTickTaskManager::RunTickGroup() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Engine\Private\TickTaskManager.cpp:1590]
FactoryGame_Engine_Win64_Shipping!UWorld::Tick() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Engine\Private\LevelTick.cpp:1480]
FactoryGame_Engine_Win64_Shipping!UGameEngine::Tick() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Engine\Private\GameEngine.cpp:1802]
FactoryGame_FactoryGame_Win64_Shipping!UFGGameEngine::Tick() [D:\ws\SB-211116092526-440\UE4\Games\FactoryGame\Source\FactoryGame\Private\FGGameEngine.cpp:16]
FactoryGame_Win64_Shipping!FEngineLoop::Tick() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Launch\Private\LaunchEngineLoop.cpp:4896]
FactoryGame_Win64_Shipping!GuardedMain() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Launch\Private\Launch.cpp:169]
FactoryGame_Win64_Shipping!GuardedMainWrapper() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Launch\Private\Windows\LaunchWindows.cpp:137]
FactoryGame_Win64_Shipping!WinMain() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Launch\Private\Windows\LaunchWindows.cpp:268]
FactoryGame_Win64_Shipping!__scrt_common_main_seh() [d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288]
kernel32
ntdll

and


Version: 176027, IsEditor: No, IsPerforceBuild: No, BuildConfiguration: Shipping, Launcher: Steam, NetMode: Listen Server, IsUsingMods: Yes

Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x0000000000000028

FactoryGame_FicsItNetworks_Win64_Shipping!luaD_call() [G:\Projects\eris\src\ldo.c:507]
FactoryGame_FicsItNetworks_Win64_Shipping!luaD_rawrunprotected() [G:\Projects\eris\src\ldo.c:146]
FactoryGame_FicsItNetworks_Win64_Shipping!lua_resume() [G:\Projects\eris\src\ldo.c:680]
FactoryGame_FicsItNetworks_Win64_Shipping!luaResume() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\FicsItKernel\Processor\Lua\LuaProcessor.cpp:773]
FactoryGame_FicsItNetworks_Win64_Shipping!luaD_call() [G:\Projects\eris\src\ldo.c:483]
FactoryGame_FicsItNetworks_Win64_Shipping!luaV_execute() [G:\Projects\eris\src\lvm.c:1615]
FactoryGame_FicsItNetworks_Win64_Shipping!resume() [G:\Projects\eris\src\ldo.c:646]
FactoryGame_FicsItNetworks_Win64_Shipping!luaD_rawrunprotected() [G:\Projects\eris\src\ldo.c:146]
FactoryGame_FicsItNetworks_Win64_Shipping!lua_resume() [G:\Projects\eris\src\ldo.c:680]
FactoryGame_FicsItNetworks_Win64_Shipping!UFINLuaProcessor::LuaTick() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\FicsItKernel\Processor\Lua\LuaProcessor.cpp:561]
FactoryGame_FicsItNetworks_Win64_Shipping!FFINLuaProcessorTick::syncTick() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\FicsItKernel\Processor\Lua\LuaProcessor.cpp:169]
FactoryGame_FicsItNetworks_Win64_Shipping!UFINKernelSystem::Tick() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\FicsItKernel\FicsItKernel.cpp:123]
FactoryGame_FicsItNetworks_Win64_Shipping!AFINComputerCase::Factory_Tick() [G:\Projects\Satisfactory\SatisfactoryModLoader\Plugins\FicsItNetworks\Source\FicsItNetworks\Computer\FINComputerCase.cpp:146]
FactoryGame_FactoryGame_Win64_Shipping!<lambda_9a1b75034c50804c2f23014618340d68>::operator()() [D:\ws\SB-211116092526-440\UE4\Games\FactoryGame\Source\FactoryGame\Private\FGBuildableSubsystem.cpp:532]
FactoryGame_FactoryGame_Win64_Shipping!ParallelForImpl::TParallelForData<TFunctionRef<void __cdecl(int)> >::Process() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Core\Public\Async\ParallelFor.h:177]
FactoryGame_FactoryGame_Win64_Shipping!TGraphTask<ParallelForImpl::TParallelForTask<TFunctionRef<void __cdecl(int)> > >::ExecuteTask() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Core\Public\Async\TaskGraphInterfaces.h:886]
FactoryGame_Core_Win64_Shipping!FTaskThreadAnyThread::ProcessTasksUntilQuit() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Core\Private\Async\TaskGraph.cpp:887]
FactoryGame_Core_Win64_Shipping!FTaskThreadBase::Run() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Core\Private\Async\TaskGraph.cpp:541]
FactoryGame_Core_Win64_Shipping!FRunnableThreadWin::Run() [D:\ws\SB-211116092526-440\UE4\Engine\Source\Runtime\Core\Private\Windows\WindowsRunnableThread.cpp:86]

Here is my code: https://gist.github.com/TheGreyDiamond/98fa0b3154b09b8ca59160d3d65c2788 (please do not judge it too much)

Panakotta00 commented 2 years ago

can you try to scrap most out of your code but still are able to reproduce the issue, and the post it please ^^

Panakotta00 commented 1 year ago

i cant reproduce the issue... do you still have the issue?

Panakotta00 commented 1 year ago

Should be fixed in the next update