Feedback from Kirsty

[kirsty-nology]

Heey this Kirsty, feel free to message me on Slack if you want any clarification on the points below. I will give you both positive and constructive feedback on your project.

---

Goals

1. A working Game
2. Practice using Git and GitHub flow
3. Apply what you are learning
4. Collision detection is infamously difficult in JS

---

Requirements

• PSEUDOCODE: - Great descriptive bits of pseudocode
• Public repository on GitHub with a readme. - Yup! Have a shot at formatting the README to make it even prettier :)
• 15 Git commits for the project and repo on GitHub. - 16 commits nice one
• Your JS code must be formatted as functions - Yup
• You must use click or key-press events in JavaScript to trigger the events in the game. (No refreshing to start the game again!!) - Yup, no restart yet but can see you have as a next step in your README
• Do not follow a tutorial to create your game. - hmmmm I'm not sure, hopefully not!
• We would like you to take a Mobile-first approach to the implementation. It needs to work on different device widths. - not really but can be easily adjusted to be so
• Add a link to this project on your portfolio – this is your first chance to show off your web skills!

---

The UI

Positive

• Like the lofi feel
• Hard game!

Constructive

• Look at creating some instructions
• Need to have some display options that are different for desktop/mobile
• Could be a bit more styled

---

The Code

Positive

• Good to see all query selectors at the top
• Good to see global variables near the top also
• Like the psuedocode describing what each function is doing
• Nifty function generating the squares and giving them id's
• Good naming of functions, readable
• Great to see functions calling other functions (generateInfo)
• Great to see the use of an empty callback in the event listeners
• Really smart little function to test for nearby mines... very smart!!

Constructive

• Please remove all commented out code in the future, just add a new branch with that stuff next time
• Ideally remove DOM from functions so they are pure... easier to test!

[Parham2002]

Thank you very much for the feedback, Kirsty!