Closed gbiellem closed 3 years ago
Hey @gbiellem
We didn't intend to publish these events to the outside world. Most of them are now only handled in-memory any way. Do you need any specific ones available?
Regarding the .NET standard support, let me raise a separate issue and it will be handled in the next release. We missed that aspect :-(
Hi @SzymonPobiega,
What i was specifically after were the MessageFailureResolvedByRetry and MessageFailureResolvedManually events.
@gbiellem If I remember correctly we were had some concerns related to worst-case volume of these messages (the throughput of the MessageFailureResolvedByRetry
can be as high as the audit ingestion). But that's something we might want to re-evaluate now that we moved to V7 of NSB and the transports are much faster.
@gbiellem are you fine with me editing the title to reflect this better?
@SzymonPobiega Go for it
@SzymonPobiega I think you goofed in the rename. You've already opened an issue for ,Net Core support ( #1446). I think you meant to rename this to address reevaluating the exposed events.
related to this and the SC PR depends on this being merged: https://github.com/Particular/ServiceControl.Contracts/issues/32
Opened a PR for
If we have more time I can look at
New contracts done: https://github.com/Particular/ServiceControl.Contracts/pull/46 Contracts release draft: https://github.com/Particular/ServiceControl.Contracts/releases/tag/untagged-16a0073ba76443932dd6
PR for ServiceControl: https://github.com/Particular/ServiceControl/pull/2465
updated docs PR https://github.com/Particular/docs.particular.net/pull/5289
Working with @tmasternak on an Azure Application Insights sample
@tmasternak and I have a PR in progress on docs: https://github.com/Particular/docs.particular.net/pull/5289
It includes updates to the current docs and a new sample showing Azure App Insights integration
From Slack @mikeminutillo's summary:
To summarize the conversation:
The outcome is that we will introduce a config flag to turn off the publishing of integration events.
Hi Particles
Looking at https://github.com/Particular/ServiceControl/tree/develop/src/ServiceControl/Contracts there are a plethora of events that are published however the current ServiceControl Contracts nuget only exposes 5 of them for external integration.
The current nuget also only supports full framework. Any chance it can be updated and published as .net standard rather than full framework?