Particular / ServiceControl

Backend for ServiceInsight and ServicePulse
https://docs.particular.net/servicecontrol/
Other
52 stars 47 forks source link

Create Endpoint list API for ServiceInsight #890

Open mikeminutillo opened 7 years ago

mikeminutillo commented 7 years ago

When ServiceInsight is opened the user is presented with a list of endpoints. Clicking one of those endpoints filters the list of messages to those which have been sent or received by that endpoint.

That list comes from an API exposed by ServiceControl that is intended for ServicePulse. It is intended for monitoring purposes. It contains every endpoint that has ever sent or received a message (even if there are no messages currently in the ServiceControl database). It also contains endpoints which have the heartbeat plugin installed but have never sent or received a message.

What ServiceInsight really needs is a way of filtering messages by endpoint. While this data looks very similar, it is not the same and requires a separate API.

mikeminutillo commented 7 years ago

NOTE: This change can be implemented as a Map-Reduce index over the FailedMessage and ProcessedMessage document collections.

HEskandari commented 7 years ago

@Particular/servicecontrol-maintainers Is this issue still planned?

WilliamBZA commented 7 years ago

@HEskandari Perhaps part of your request can be covered by a feature developed as part of the launch wave:

https://github.com/Particular/ServiceControl/blob/ca042238fb0ca95f87c2e1ec371cdfc74b490976/src/ServiceControl/Recoverability/API/FailureGroupsApi.cs#L30-L36

If you use the classifier Endpoint Name it will return all the failed messages for a group. This won't return audit messages however.

mikeminutillo commented 7 years ago

@HEskandari it is planned but not scheduled. Did you have a specific need for it now?

HEskandari commented 7 years ago

@mikeminutillo this issue in SI is apparently waiting for it.