search

Partonetrain / rpgattr

Adds compatibility to Spell Engine/Jewelry item configs for many modded attributes
Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

Botania crit mixin doesn't work #2

Open Partonetrain opened 4 months ago

Partonetrain commented 4 months ago

Unfortunately this is difficult to debug without the PortingLib Issue #103 fixed, which ZenithAttributes depends on.

Partonetrain commented 1 month ago

Partially fixed in 2.2.0. All wills excepts Verac (the one that makes critical hits ignore armor) should work. Verac doesn't work because it modifies the DamageSource from the player, but the lambda apothCriticalStrike() is run on LivingEntity#hurt (which occurs after Player#attack where the DamageSource is supplied from)