Use base64 encoding for exec() binary safe output when deriving share…

PayU-EMEA / apple-pay

This library is used to decode tokens for Apple Pay.

48 stars 31 forks source link

Closed sun0x0001 closed 5 years ago

sun0x0001 commented 6 years ago

…d key (may contain CR/LF, etc)

costyoancea commented 6 years ago

@sun0x0001 : why not use trim?

sun0x0001 commented 6 years ago

Hi! Because CR/LF may be contained inside the key, splitting it into several lines in $execOutput variable, but only $execOutput[0] used.

costyoancea commented 6 years ago

pipeline need to be green

dsizov commented 5 years ago

Hi @trydocatch , why this PR was not merged? Problem still exists for some apple pay tokens, because of line breaks in the output.

trydocatch commented 5 years ago

Issue confirmed

trydocatch commented 5 years ago

@sun0x0001 Thank you for the fix!