search

PayU-EMEA / apple-pay

This library is used to decode tokens for Apple Pay.
48 stars 31 forks source link

Not compatible with symfony/process:^5.0 #13

Closed willemstuursma closed 3 years ago

willemstuursma commented 4 years ago

The package is not compatible with symfony/process:^5.0.

No need to work on it yourself, but I may open a PR one day to sort it out and would like it to be tracked here.

trydocatch commented 4 years ago

It looks like symfony/process 5.0 requires min PHP version 7.2.5. So for who's using older versions of PHP, this wouldn't work.

willemstuursma commented 4 years ago

For PCI-DSS environments I guess PHP 7.2 is the minimum, as it is the lowest PHP version that still gets security updates.

drealecs commented 3 years ago

I think what @willemstuursma intended here would be to change in the composer.json require:

"symfony/process": "^3.4|^4.0"

with

"symfony/process": "^3.4|^4.0|^5.0"

That would still work with older PHP versions that would use older symfony/process versions.

Just to have it documented here, the main change would be in OpenSslService.php where the Process ctor now requires an array as commandline parameter. Array version should also work for older mentioned versions, from what I know.

willemstuursma commented 3 years ago

Cheers @drealecs.