search

Pelagicore / vagrant-cookbook

A repository of vagrant configuration snippets
Mozilla Public License 2.0
13 stars 33 forks source link

Remove deprecated deps/testing-upgrade.sh #85

Closed sashko closed 5 years ago

sashko commented 5 years ago

Signed-off-by: Oleksandr Kravchuk oleksandr.kravchuk@pelagicore.com

sashko commented 5 years ago

Are we sure that downstream projects aren't using this?

Eeegggh... no, we are not :)

thenor commented 5 years ago

As I understand it, the way our other teams are working, their projects are not dependent on this script being removed. In general I believe we don't have any teams at this time that are rebasing towards our master, so this type of work won't have a big impact.

rpannek commented 5 years ago

We're using the vagrant-cookbook atcively, although I would need to dive deeper into it to understand if we're using this script or not. Btw. I find it impossible to review commits like this with zero context in the commit message on why things are happening. Nobody needs the info what is happening because they always can look into the source code changes themselves but why stuff is happening is the most important part of a commit message and it's basically always non existent. I thought you guys were following the GNOME Commit Message guidelines: https://wiki.gnome.org/Git/CommitMessages/ but it doesn't look like that. If there is no description on why things are happening in the commit message then I don't think it makes sense to add me as a reviewer.