search

PennLINC / xcp_d

Post-processing of fMRIPrep, NiBabies, and HCP outputs
https://xcp-d.readthedocs.io
BSD 3-Clause "New" or "Revised" License
76 stars 23 forks source link

Correct documentation regarding Freesurfer #1277

Closed tsalo closed 12 hours ago

tsalo commented 1 day ago

Closes none, but makes it clear that Freesurfer derivatives are no longer used.

Also addresses issues stemming from https://github.com/PennLINC/xcpd_build/pull/28, https://github.com/PennLINC/xcpd_build/pull/29, https://github.com/PennLINC/xcpd_build/pull/30, https://github.com/PennLINC/xcpd_build/pull/31, https://github.com/PennLINC/xcpd_build/pull/33, https://github.com/PennLINC/xcpd_build/pull/35, https://github.com/PennLINC/xcpd_build/pull/36, https://github.com/PennLINC/xcpd_build/pull/37, https://github.com/PennLINC/xcpd_build/pull/38, and https://github.com/PennLINC/xcpd_build/pull/39.

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.63%. Comparing base (b766391) to head (b6c0a70). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/interfaces/ants.py 66.66% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1277 +/- ## ========================================== + Coverage 78.55% 78.63% +0.08% ========================================== Files 59 59 Lines 7312 7308 -4 Branches 1105 1106 +1 ========================================== + Hits 5744 5747 +3 + Misses 1279 1273 -6 + Partials 289 288 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 18 hours ago

The last round of changes to the build image (https://github.com/PennLINC/xcpd_build/pull/38) didn't fix the problem:

3dReHo: error while loading shared libraries: libgsl.so.0: cannot open shared object file: No such file or directory
tsalo commented 13 hours ago

Finally!!! Also, ANTS changed the filename template for CompositeTransformUtil, so I had to make a modified version of the interface instead of importing it from nipype.