PennLINC / xcp_d

Post-processing of fMRIPrep, NiBabies, and HCP outputs
https://xcp-d.readthedocs.io
BSD 3-Clause "New" or "Revised" License
78 stars 26 forks source link

Write out correlations when `--create-matrices` doesn't include "all" #1326

Closed tsalo closed 2 days ago

tsalo commented 4 days ago

Closes none, but addresses a bug identified in https://neurostars.org/t/filenotfounderror-no-bold-data-found-in-allowed-spaces-fslr/30968.

Changes proposed in this pull request

tsalo commented 4 days ago

It looks like this might require a bit more thought.

tsalo commented 3 days ago

Maybe I can just force dcan_correlation_lengths to be ["all"] for linc mode and drop output_correlations?

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (e19b7b1) to head (ff1308f). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/workflows/bold/concatenation.py 0.00% 7 Missing and 1 partial :warning:
xcp_d/workflows/bold/connectivity.py 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1326 +/- ## ========================================== - Coverage 79.03% 78.96% -0.08% ========================================== Files 59 59 Lines 7408 7406 -2 Branches 961 962 +1 ========================================== - Hits 5855 5848 -7 - Misses 1261 1268 +7 + Partials 292 290 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: