search

PennLINC / xcp_d

Post-processing of fMRIPrep, NiBabies, and HCP outputs
https://xcp-d.readthedocs.io
BSD 3-Clause "New" or "Revised" License
78 stars 26 forks source link

HBCD software standards requirements #1332

Closed LuciMoore closed 14 minutes ago

LuciMoore commented 13 hours ago

The following updates are required to meet Bronze badge status for NMIND review:

The current checklist submitted for review is here: https://github.com/nmind/proceedings/issues/16

Just let me know if you feel you'll be able to address these points within the next week or not. If the timeline for these updates isn't realistic given the short time frame, then I can have NMIND move forward with the review and you can make updates+resubmit the checklist at a later date to achieve a higher badge rating. so just let me know either way!

For the second item, you could consider pointing to https://cdnis-brain.readthedocs.io/infant-qa/. This outlines the CDNI standards for performing quality control based on executive summary images from abcd-hcp-pipeline, so should work for XCP-D as well. It doesn't necessarily address correct software behavior, but could help users determine whether their outputs look reasonable or not

tsalo commented 5 hours ago

There's documentation in https://xcp-d.readthedocs.io/en/latest/contributing.html#running-tests-locally about running tests. Does that cover it?

LuciMoore commented 14 minutes ago

I think that should work, yes. The person who did the initial review must have missed that section. I'll mark these items as complete and indicate to NMIND that XCP-D is ready for final review

tsalo commented 8 minutes ago

I only added it a couple of days ago so it might not have been up when the reviewer looked.