PennLINC / xcp_d

Post-processing of fMRIPrep, NiBabies, and HCP outputs
https://xcp-d.readthedocs.io
BSD 3-Clause "New" or "Revised" License
76 stars 23 forks source link

Harmonize atlases across XCP, QSIPrep #551

Closed kahinimehta closed 1 year ago

kahinimehta commented 1 year ago

Duplicate of https://github.com/PennLINC/informatics_misc/issues/49

tsalo commented 1 year ago

Notes from meeting today (lots of overlap with the original checklist/plan):

  1. Upload NLin6-1x1x1 versions of all atlases we want to the Box xcpd folder.
  2. Upload fsLR-32k versions of all atlases, preferably with separate files for cortical and subcortical atlases to the same folder. This may require some work to get the subcortical atlases in this format.
  3. Come up with a good format for metadata, node labels, and network labels. qsiprep currently uses a single JSON file for all atlases, xcpd uses text files (.1D), templateflow uses TSV files. Basically, there's room to standardize. The BIDS Atlas BEP is very unstable and may not be worth adhering to.
  4. Write code to do the following:
    1. Combine NLin6 cortical and subcortical atlases, per qsiprep's requirements.
    2. Combine the associated metadata and label files, as needed.
    3. Warp the combined NLin6 nifti atlases to 2009c space.
    4. Enforce LPS+ orientation.
    5. Write the new expanded atlases and their sidecar files to the qsiprep Box folder.
  5. Upload the code to the code Box folder.
  6. Update the Box URL in the qsiprep Docker image.
  7. Update the xcpd Docker image to download the atlases from the xcpd Box folder.
  8. Remove the atlases from the xcpd repo.
  9. Update xcpd to combine atlases as needed. This may require some work to use the new subcortical CIFTI atlases.
  10. A community-affiliation csv?
kahinimehta commented 1 year ago
tsalo commented 1 year ago

I've opened https://github.com/templateflow/registration-framework/issues/3 to request info about good surrogate T1w images for the registration workflow.

tsalo commented 1 year ago

AtlasPack is now deploying to DockerHub (https://hub.docker.com/r/pennlinc/atlaspack/tags), so I can start incorporating our new atlases into XCP-D.

tsalo commented 1 year ago

I think the question is whether we want to replace the current Schaefer atlases with the new combined atlases, or simply add the new atlases on top of the old ones instead. I'd prefer to just replace the atlases, since the Schaefers are included in the new combined atlases (and thus the Schaefers are redundant on their own), but others may feel more strongly about this.