search

Peripli / specification

Service Manager Specification
Apache License 2.0
11 stars 4 forks source link

Improve review process #19

Closed dpanayotov closed 6 years ago

dpanayotov commented 6 years ago

Pullapprove-like feature is available in Github by using Code Owners[1]. I think it would be nice to have this for the specification. Have a list of "maintainers" from which a subset must approve a specific pull request before it can be merged. Granted, it lacks the "disable merge" functionality of pullapprove but I think that's sufficient.

[1]https://blog.github.com/2017-07-06-introducing-code-owners/

dzahariev commented 6 years ago

For specification repository we change the configuration in following way:

  1. We protect the master branch even for administrators
  2. Always Require pull request reviews before merging
  3. Require 3 approvals before merge
  4. Dismiss stale pull request approvals when new commits are pushed
  5. Require status checks to pass before merging
  6. Require branches to be up to date before merging

If this configuration not works for some cases will adjusts it in to the future.