search

Perl-Evozon / PearlBee

116 stars 44 forks source link

Proper namespace #1

Closed xsawyerx closed 10 years ago

xsawyerx commented 10 years ago

The current namespace is "perlblog" and "Model". These are both unsuitable.

Additionally, the repo should then be renamed to reflect the new namespace.

andrei-cacio commented 10 years ago

Thanks Sawyer for the fast feedback! I will fix the namespace issue but what name should I give to the Model class?

xsawyerx commented 10 years ago

PearlBee should be the namespace. The model can go under PearlBee::Model. I'll submit a pull request with that commit this evening.

Also, it will completely remove tab spaces from the code, I'm warning you in advance. :)

ghost commented 10 years ago

I have a PR that I believe takes care of this issue. No offense intended Mr. XsawyerX, you do so much for Perl ready!

However, I am getting an issue that I think is unrelated or it could be something I missed. Therefore, feel free to reject it. :) ( I did confirm that I get the same errors without my changes. )

BTW - My PR seems to have created another issue. Did I miss something that would have attached it to this issue?

ghost commented 10 years ago

It helps to install ALL the dependencies. :)

ctreptow@vm-1:~/Blog$ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.
t
t/001_base.t ......... ok   
t/002_index_route.t .. ok   
All tests successful.
Files=2, Tests=3,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.66 cusr  0.28 csys =  1.98 CPU)
Result: PASS
ctreptow@vm-1:~/Blog$
xsawyerx commented 10 years ago

It seems good except for the Model that still needs to be renamed.

PearlBee::Model etc.

Excellent work!

ghost commented 10 years ago

Updated! Check it out if you have a moment.

xsawyerx commented 10 years ago

All good except for line no. 38 in the config file config.yml:

          schema_class: Model::Schema

Should be changed to new class.

ghost commented 10 years ago

Thank you! That was weird, I had it changed but needed to commit that one file, for some reason.

xsawyerx commented 10 years ago

Seems excellent to me. @ctreptow, Great stuff there!

Now up to @andrei-cacio to decide, and merge if so.

ghost commented 10 years ago

Hey, I can sleep soundly knowing it is "SawyerX approved"!! :)