search

PerplexDigital / Perplex.ContentBlocks

Block based content editor for Umbraco
MIT License
31 stars 15 forks source link

Perplex block UI hides grid layout settings #63

Closed Wiggee11 closed 2 years ago

Wiggee11 commented 2 years ago

The Perplex UI hides the settings cog for grid layouts when in a Perplex block so grid layout settings are not useable.

The grid layout has settings applied which are not accessible when using with a Perplex block. perpelx grid

Deleting the umb-editor-sub-header element, the settings cog is revealed. perpelx grid 2

PerplexDaniel commented 2 years ago

Yeah that is not right, we should not be touching the UI of nested editors. I have not actually seen the Grid being used inside ContentBlocks, that's quite interesting since usually ContentBlocks is used as a replacement of Grid (like) editors.

Deleting the umb-editor-sub-header element, the settings cog is revealed.

Isn't the umb-editor-sub-header part of the Grid itself? I don't think that's an element created by our package so it's not like we can just remove that. However there is probably some CSS rule inside the .perplex-content-blocks container that hides the grid controls. If you can pinpoint those we can have a look at how to fix that. Of course we can also have a look ourselves at some point but that might take bit longer.

Wiggee11 commented 2 years ago

We create structured blocks as you'd expect but our clients always require the ability to create grid layout blocks.

I had a quick dive into the generated HTML but couldn't quickly identify what CSS was causing the issue. I wasn't sure if the um-editor-sub-header was something generated by Perplex or just using the default Umbraco editor.

I might take a further look into this when I get a spare moment.

PerplexDaniel commented 2 years ago

Generally all umb-... prefixed components are from Umbraco itself, if you add the Grid property directly to a Document Type I assume that element is also present. I will also try to have a look next week.

PerplexDaniel commented 2 years ago

@Wiggee11 I cannot reproduce this, I see the settings cogs just fine. Which version of Umbraco and ContentBlocks are you using? I tested in both v8 + v9 in the latest version (2.1.4). I see both cogs without deleting any elements:

cb

Wiggee11 commented 2 years ago

I am using Umbraco 8.18.4 and Perplex.ContentBlocks 1.7.0. I'll try updating PCB and see what happens...

PerplexDaniel commented 2 years ago

If you any updates feel free to re-open. Closing this since it has been over 2 months.