Closed shripalsoni04 closed 7 years ago
Hi @PeterStaev , Thanks for merging this PR. I think it is not yet published to NPM. It will be great if you can publish it to NPM. Thanks.
Hey @shripalsoni04 , sorry the version is now published.
No problem @PeterStaev . Thanks for publishing it. It is working as expected now 👍
Currently when we use this plugin and if we prepare AOT build using
nativescript-dev-webpack
plugin, I found that@angular/compiler/@angular/compiler.es5.js
(size: ~966KB) is also getting bundled inbundle.js
. Ideally this file should not get bundled in AOT builds.I tried to find the root cause using webpack analyze tool and found that it is getting included because of below line:
nativescript-drop-down/angular/index.ts
This
nativescript-angular
modules is requiringnativescript-angular/platform
and that is importing@angular/compiler
.When I changed the above import line to as shown below, the final build did not included the
compiler.es5.js
, resulting in smaller and faster build compared to before.If you find this proper, then please apply this change. Let me know in case of any issues/concerns.
Thanks.