search

PeterStaev / NativeScript-Drop-Down

A NativeScript DropDown widget.
Apache License 2.0
105 stars 65 forks source link

Nativescript angular 4.4.x #138

Closed jogboms closed 6 years ago

PeterStaev commented 6 years ago

Hey @jogboms , thanks for your contribution! I have couple of questions - do we really need to update peer-deps for TNS to be 3.3 at least? I don't see anything in the change log for 3.3 that mentioned Angular 4.4. Cant we just update the Angular deps and nativescript-angular module?

jogboms commented 6 years ago

@PeterStaev that's true. I couldn't find one of @vakrilov's comment where he said something about a bug being fixed on the @next branch of tns-core-modules that fixes a bug in v4.4.

vakrilov commented 6 years ago

@jogboms Nice PR! I believe this is the issue you are talking about (https://github.com/NativeScript/nativescript-angular/issues/992). It will be fixed in the tns-core-modules. It is not related to the nativescript-angular/value-accessors/base-value-accessor fix you did here though.

jogboms commented 6 years ago

Couldn't tell for sure what bug it was, only remembered there was one. 😊