PeterStaev / NativeScript-Drop-Down

A NativeScript DropDown widget.
Apache License 2.0
105 stars 65 forks source link

Error with NativeScript 6.2 #229

Closed jabrware closed 4 years ago

jabrware commented 4 years ago

After upgrading to NS 6.2 I am getting this error when building project:

error TS2307: Cannot find module 'nativescript-angular/forms/value-accessors/base-value-accessor'.

PeterStaev commented 4 years ago

@ashraf-jabr , make sure your project uses the "old" package of "nativescript-angular" and not the new one "@nativescript/angular". I will be adjusting the ProPlugins version to use the new scope packages soon 😄

Sahkay commented 4 years ago

I am using nativescript-angular (without the @) myself and am getting the same error now. I am currently looking for a manual fix but thought I'd post here in case I am more likely to get a response if I comment earlier due to timezones. EDIT: managed to fix it by using a compatibility fix and reinstalling webpack but that may have been a seperate issue.

PeterStaev commented 4 years ago

Seems there might have been some code reorganization in the angular package. I have to check what might be the problem.

DickSmith commented 4 years ago

@ashraf-jabr @Sahkay In your webpack.config.js change the alias to this:

     alias: {
        "~": appFullPath,
        "nativescript-angular": "@nativescript/angular",
      },
jabrware commented 4 years ago

@DickSmith , I tried changing the alias but it still not working, maybe I miss something. However, my project uses 'nativescript-angular' not '@nativescript/angular' but it gives the same error at build time.

PeterStaev commented 4 years ago

Just a bit of a follow up - I just updated the ProPlugins demo-ng project using tns update and all seems to be working fine. So you should try to nuke your platforms/node_modules and try updating the app using the built in command.

jabrware commented 4 years ago

I think that 'base-value-accessor' is missed from the new version of 'nativescript-angular' package

PeterStaev commented 4 years ago

@ashraf-jabr , like I said above, I'm having no problems after upgrading the demo apps in ProPlugins, and they import the accessor from the same place.

jabrware commented 4 years ago

It now build with no errors after updating to "nativescript-angular": "8.20.1"