PetoiCamp / OpenCatEsp32

An ESP32-based open source quadruped robot pet framework for developing Boston Dynamics-style four-legged robots that are perfect for STEM, coding & robotics education, IoT robotics applications, AI-enhanced robotics application services, research, and DIY robotics kit development.
MIT License
97 stars 31 forks source link

Check esp32 library version #22

Open FlexoTim opened 4 months ago

FlexoTim commented 4 months ago

A plea.

I've been tripped up a number of times by the esp32 library version issue. OpenCatEsp32 requires the esp32 library version of 2.0.12, which is obsolete and no longer supported by Espressif. The Arduino IDE is constantly asking to update to the current version (3.0.4 now) and if you do then you have trouble with the OpenCatEsp32 project. It would helpful if OpenCatEsp32.h would check the library version, e.g.,

`#if ESP_ARDUINO_VERSION != ESP_ARDUINO_VERSION_VAL(2, 0, 11)

error esp32 v 2.0.12 required

endif

`


`
este-este commented 4 months ago

Personally, I defer to the Petoi team as to the return on investment to be had by updating the OpenCatEsp32 code to use the current esp32 library. I am not sure what support Petoi gets from Espressif but if it is not much then the lack of support for the older library version may not matter.

Aside from support, I am not aware of any improvements in the current esp32 library that would benefit our robotics experiences with Bittle. My impression is that many changes are due to Espressif's need to support new features on their more recent chips, something that Bittle users would not benefit from. However, if there is a significant defect in the older esp32 library that affects Bittle, I certainly would like to hear about it.

As for the Arduino IDE nagging to do updates for the IDE, the boards and the libraries, I just turned that preference off as follows

My Arduino configuration is static and has been for at least 2 years. The only changes I make are to my copy of the OpenCatEsp32 source code and, so far, I haven't needed to update anything in the Arduino IDE during that time. I am very much an "if it's not broken, don't fix it" kind of person.

borntoleave commented 4 months ago

I don't plan to upgrade to the new ESP32 configuration soon. You're right that the updates are primarily for Espressif's new features, which we are not using.

Regarding Arduino IDE, it's relatively stable with updates. Both 1.8.x and 2.x work. Most of the changes are in the UI.

On Sat, Aug 3, 2024 at 5:41 AM este-este @.***> wrote:

Personally, I defer to the Petoi team as to the return on investment to be had by updating the OpenCatEsp32 code to use the current esp32 library. I am not sure what support Petoi gets from Espressif but if it is not much then the lack of support for the older library version may not matter.

Aside from support, I am not aware of any improvements in the current esp32 library that would benefit our robotics experiences with Bittle. My impression is that many changes are due to Espressif's need to support new features on their more recent chips, something that Bittle users would not benefit from. However, if there is a significant defect in the older esp32 library that affects Bittle, I certainly would like to hear about it.

As for the Arduino IDE nagging to do updates for the IDE, the boards and the libraries, I just turned that preference off as follows

My Arduino configuration is static and has been for at least 2 years. The only changes I make are to my copy of the OpenCatEsp32 source code and, so far, I haven't needed to update anything in the Arduino IDE during that time. I am very much an "if it's not broken, don't fix it" kind of person.

— Reply to this email directly, view it on GitHub https://github.com/PetoiCamp/OpenCatEsp32/issues/22#issuecomment-2266178257, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKLZGAIFVIUUMJ7EIEZKUDZPP4ITAVCNFSM6AAAAABL5A5YASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRWGE3TQMRVG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- ~~ Rongzhong Li, PhD http://borntoleave.github.io

FlexoTim commented 3 months ago

I wasn't requesting to upgrade the library. I was requesting the detection of the required library. This checks that the esp32 library version is 2.0.12

if ESP_ARDUINO_VERSION != ESP_ARDUINO_VERSION_VAL(2, 0, 11)

error esp32 v 2.0.12 required

endif

este-este commented 3 months ago

Got it! That sounds like a good idea to me, though I assume you mean:

if ESP_ARDUINO_VERSION != ESP_ARDUINO_VERSION_VAL(2, 0, 12)

FlexoTim commented 3 months ago

I tested what is in the header esp_arduino_version.h The patch number for v2.0.12 is 11.

este-este commented 3 months ago

Well, that is unexpectedly confusing. Thanks for figuring that out!