PharmaLedger-IMI / ctr-workspace

UC8 Clinical Trials Recruitment
MIT License
2 stars 0 forks source link

Design differences between patient-ssapp and clickeable prototype #24

Open joaoluis-pdm opened 3 years ago

joaoluis-pdm commented 3 years ago

@lehialessandro sabes alguma maniera fácila de mudar as cores do ionic para ficarem iguais às do protótipo ? Eu andei a brincar um bocado com o https://github.com/PharmaLedger-IMI/ctr-workspace/blob/master/ctr-patient/patient-ssapp/code/assets/skin.css mas não saíu como esperava. Era algo que saberias resolver ?

joaoluis-pdm commented 3 years ago

Fix ctr-workspace/ctr-patient/patient-ssapp/code/templates/clinicaltrialinfo10.html and ctr-workspace/ctr-patient/patient-ssapp/code/templates/matchrequestnew60info.html

image

Use the same icons as under https://github.com/PharmaLedger-IMI/ctr-workspace/tree/master/ctr-backoffice-frontend/src/assets

image

Is is probably better to make a copy of the needed .png icons https://github.com/PharmaLedger-IMI/ctr-workspace/tree/master/ctr-backoffice-frontend/src/assets to https://github.com/PharmaLedger-IMI/ctr-workspace/tree/master/ctr-patient/apihub-root/assets/images

Style changes to make the patient-ssapp more like the physician backoffice are welcome.

joaoluis-pdm commented 3 years ago

@lehialessandro I will ask you for help regarding the "Eligibility criteria" box (from the clickeable prototype) image

Regarding the box, can you help elaborate an HTML + CSS snippet for the "list items" ?

Note: For now, each list item just has 1 line of text (Example: just "Psoriatic arthritis diganosis", not "Psoriatic arthritis diganosis ; We found a diagnosis in your health record").

Instead of just a green icon image that means "match", I also need

It would be great if this HTML snippet only differs in li (list item classes) so that the same HTML snipped can be used on the patrient-ssapp and on the ctr-backoffice-frontend. (I just need to port the CSS to both applications).

joaoluis-pdm commented 3 years ago

@lehialessandro do you know of an equivalent to https://material.angular.io/components/progress-spinner/examples in ionic ? (The "Progress Indicators" in https://ionicframework.com/docs/api/loading do not seem adequate to display the "percentage" (Match confidence score).

joaoluis-pdm commented 3 years ago

In v0.7.2-gc365093 in the backoffice , the neutral mark does not appear

image

although the asset https://ctr-dev.pharmaledger.pdmfc.com/backoffice/assets/neutral.svg exists, and the class="neutral-img" is placed on the span.

How to reproduce: 1 - login to https://ctr-dev.pharmaledger.pdmfc.com/backoffice/dashboard?type=SponsorUser&v=0.7.1 with username pfizeruser1@somesponsor.com and password 123456 2 - view the trial Psoriatic Arthritis5 at URL https://ctr-dev.pharmaledger.pdmfc.com/backoffice/trialdetails/f6792fa1-c2a4-4f93-be06-2558ad4a00b7

joaoluis-pdm commented 2 years ago

Componente application.component: image

(Figma is different, but style should be similar... Figma: image

pccosta-pdm commented 2 years ago

@lehialessandro added and changed the progress bar to component "step-progress-bar" on "ClinicalTrialAnsXX" and "MatchRequestNewXX" (template/controllers)

After removing the css from the last page, some issues appeared on web-component, probably due to shadow-dom, can you check please?

lehialessandro commented 2 years ago

Finished component: clinicaltrial-detail

screen

@joaoluis-pdm

lehialessandro commented 2 years ago

Next component: clinicaltrial-edit

clinicaltrial-edit

@joaoluis-pdm

lehialessandro commented 2 years ago

Next component: clinicaltrialquestiontypegroup-ghi

Screen Shot 2021-10-29 at 5 13 29 AM

@joaoluis-pdm

mcoelho-pdmfc commented 2 years ago

image

I would like both reds to be the same.

joaoluis-pdm commented 2 years ago

@lehialessandro the code related to the picture is https://github.com/PharmaLedger-IMI/ctr-workspace/blob/master/ctr-patient/patient-ssapp/code/scripts/controllers/ClinicalTrialAns10GeneralController.js#L49 and should be more a dozen files with it...

I will pick it up.

joaoluis-pdm commented 2 years ago

@lehialessandro can you pick the previous task, please... (I have several other tasks...)

joaoluis-pdm commented 2 years ago

@lehialessandro please handle also the https://github.com/PharmaLedger-IMI/ctr-workspace/blob/790598e3cf2e1e708bb0d0da9069812b594f8b33/ctr-patient/patient-ssapp/code/scripts/controllers/HealthInfoController.js#L39

Looks a bit badly formated: image

lehialessandro commented 2 years ago
Screen Shot 2022-01-25 at 5 21 16 AM
lehialessandro commented 2 years ago

ctr-trial

lehialessandro commented 2 years ago
Screen Shot 2022-01-25 at 5 21 16 AM

Done!