lforms browser freezes when a form repeatable item item is removed (by clicking on the "-")

[joaoluis-pdm]

On a form repeatable item, when an item is removed (by clicking on the "-") the browser freezes.

Using ctr-patient/lhforms/dist/lforms-29.0.3/lforms.min.js

<script src="assets/lforms/lforms.min.js"></script>

Hint: To disable minification for debugging purposes, edit the local copy of https://github.com/lhncbc/lforms/blob/master/webpack.config.js

and replace

    optimization: {
      minimizer: [

by

  optimization: {
     minimize: false,
     minimizer: [

The ctr-patient/lhforms/dist/lforms-29.0.3/lforms.min.js is still produced but no longer minified.

[joaoluis-pdm]

https://opendsu.slack.com/archives/C01D9AR924X/p1620843097006600

I have a "bug" candidate in webcardinal, that arises when webcardinal handles events from 3rd party libraries.

In this particular case, there is a 3rd party library event that seems to leave webcardinal in an infinite loop, and freezes the browser.

How to reproduce (tested in chrome):

• open https://ctr-dev.pharmaledger.pdmfc.com/patient-ssapp/loader/ , leave the default form values and press LOGIN.
• turn on the debugger with F12
• (After the loading), In the "Medical Condition" question, add something.
• click 'Add another "Medical Conditions'.
• click the "-" prefix button to remove one medical condition (any one), and the browser hangs.
• on the debugger "Sources" tab, press the pause symbol (on chrome is the "||")
• verify that the browser is paused in an infinite loop at https://github.com/webcardinal/webcardinal-core/blob/01f2db95d5e4f1d955b385d03085502551184c84/base/controllers/Controller.js#L234 (I am not exactly sure that this is the proper source, with all the bundling going on, but seems so).
• as a workaround, I tryed to change

        if (target.parentElement) {
          target = target.parentElement;
          continue;
        }

  into

        if (target.parentElement) {
          target = target.parentElement;
          continue;
        } else {
          break;
        }

  but not really sure if that is a proper solution.

Best regards! I'll be online tomorrow.

[joaoluis-pdm]

Deny  há 13 dias
Final modification / invariant: target = target.parentElementhttps://github.com/webcardinal/webcardinal-core/commit/37f1ca71f0514b7aab158a2f537c900ccca1cde0#diff-3c9c63cc5c02947e53d[…]2690b6dcc257e6f5a7f0bR253 (editado) 
João Luís (PDM)  há 7 dias
Just to confirm that the problem is fixed.