search

Piasy / BigImageViewer

Big image viewer supporting pan and zoom, with very little memory usage and full featured image loading choices. Powered by Subsampling Scale Image View, Fresco, Glide, and Picasso. Even with gif and webp support! 🍻
MIT License
3.98k stars 402 forks source link

Android X migration #123

Closed raylee4204 closed 6 years ago

Piasy commented 6 years ago

Thanks for your contribution, but I find out that there are many unnecessary changes in this pr, e.g. space, line break, could you please cancel those changes?

raylee4204 commented 6 years ago

Updated. However, you should consider uploading a codestyle you'd like to refer to.

I use Square's codestyle: https://github.com/square/java-code-styles/tree/master/configs/codestyles

Piasy commented 6 years ago

@raylee4204 Thanks for your contribution! I just come back from a vocation, I'll merge it now.

BTW, my code style is also customized from Square Android style, I'll update the README.

Piasy commented 6 years ago

@raylee4204 v1.5.5 is released, check it out :)