Big image viewer supporting pan and zoom, with very little memory usage and full featured image loading choices. Powered by Subsampling Scale Image View, Fresco, Glide, and Picasso. Even with gif and webp support! 🍻
MIT License
3.98k
stars
401
forks
source link
updated deps and minor fixes, pre animation works #172
I can no longer run away from #98,
I'm trying to prepare the work to make it better with shared animations.
But before that, I tried to fix some problems and update stuff in general, I created a PR, if you don't want to accept it, I'll just work on my fork.
What I did:
-updated to sdk 29
-updated deps
-updated gradle to 5.6.2
-updated gradle plugin 3.5.1
-update min sdk to 15, since 14 is less than 1% and not on the dashboard
-changed images urls to https when available to avoid error in newer versions of android / android studio
-don't use api on deps everywhere, this is not good practice, switched to implementation.
-removed material-dialogs, don't use a library only for a dialog in the sample app, switched to a standard dialog
-switched to material design components style for the sample app
-enabled multi dex for the sample app, cause the method limit is close.
-fixed minor errors when trivial
Suggestions:
-should we raise the min sdk to 19 or at least 17? some deps require newer versions of the ndk, and with restrictions next year (I think) it would be a good idea... I'm not making that big of a step on my own, what do you think?
I can no longer run away from #98, I'm trying to prepare the work to make it better with shared animations.
But before that, I tried to fix some problems and update stuff in general, I created a PR, if you don't want to accept it, I'll just work on my fork.
What I did:
-updated to sdk 29 -updated deps -updated gradle to 5.6.2 -updated gradle plugin 3.5.1 -update min sdk to 15, since 14 is less than 1% and not on the dashboard -changed images urls to https when available to avoid error in newer versions of android / android studio -don't use api on deps everywhere, this is not good practice, switched to implementation. -removed material-dialogs, don't use a library only for a dialog in the sample app, switched to a standard dialog -switched to material design components style for the sample app -enabled multi dex for the sample app, cause the method limit is close. -fixed minor errors when trivial
Suggestions: -should we raise the min sdk to 19 or at least 17? some deps require newer versions of the ndk, and with restrictions next year (I think) it would be a good idea... I'm not making that big of a step on my own, what do you think?