Piasy / BigImageViewer

Big image viewer supporting pan and zoom, with very little memory usage and full featured image loading choices. Powered by Subsampling Scale Image View, Fresco, Glide, and Picasso. Even with gif and webp support! 🍻
MIT License
3.98k stars 400 forks source link

Unable to use the library with minSdkVersion <17 #204

Closed tom5079 closed 4 years ago

tom5079 commented 4 years ago
implementation "com.github.piasy:GlideImageLoader:1.6.7"

with minSdkVersion <17 gives

Manifest merger failed : uses-sdk:minSdkVersion 16 cannot be smaller than version 17 declared in library [pl.droidsonroids.gif:android-gif-drawable:1.2.20]

by the way, how did you even fit the minSdk 17 library into minSdk14 library? interesting.

Piasy commented 4 years ago

If you use fresco flavor, then you can use minSdk14.

tom5079 commented 4 years ago

Then you should bump up the minSdk of glide libraries, it confused me like hell

EvgenyTerebenin commented 4 years ago

Hi! I have such message too Manifest merger failed : uses-sdk:minSdkVersion 16 cannot be smaller than version 17 declared in library [pl.droidsonroids.gif:android-gif-drawable:1.2.20] I use implementation 'com.github.piasy:GlideImageLoader:1.6.7'

Piasy commented 4 years ago

Then you should bump up the minSdk of glide libraries, it confused me like hell

As I said, it's not necessary to use 17 when glide is not used. This kind of bump up should be done in app module, just like what I did in example app module.

tom5079 commented 4 years ago

Exactly,

Then you should bump up the minSdk of glide libraries, it confused me like hell

As I said, it's not necessary to use 17 when glide is not used. This kind of bump up should be done in app module, just like what I did in example app module.

Exactly, it means I need to use 17 when I use glide. Then why the hell is the minSdk of the GlideImageViewFactory 14?

Piasy commented 4 years ago

Ha, nice catch up, I'll update it later, thank you!

Piasy commented 4 years ago

But recently I just found that Glide support load gif into normal ImageView, so I'll remove android-gif-drawable dependency instead.

tom5079 commented 4 years ago

Great, I was wondering why you used separate library for the gif handling when I can just use glide to load gif. Sounds nice 👍

Piasy commented 4 years ago

v1.7.0 is released, check it out!