search

PiervitoCreanza / IS24-AM02

This project is a Java-based implementation of the table game "Codex Naturalis", developed as the final project for the 2023/2024 Software Engineering course at Politecnico di Milano.
4 stars 0 forks source link

Improved synchronization and optimized TCPConnectionHandler #139

Closed simonecurci closed 4 months ago

ingconti commented 4 months ago

PLS make a SEPARATE piece of code and test SEPARARTELY

On 10 Jun 2024, at 15:49, Pier107 @.***> wrote:

@PiervitoCreanza commented on this pull request.

In src/main/java/it/polimi/ingsw/network/server/ServerNetworkControllerMapper.java https://github.com/PiervitoCreanza/IS24-AM02/pull/139#discussion_r1633287563:

@@ -297,8 +321,9 @@ public void sendChatMessage(String gameName, String playerName, String message, */ @Override public void disconnect(String gameName, String playerName) {

  • if (gameConnectionMapper.containsKey(gameName))
  • synchronized (gameConnectionMapper.get(gameName)) { what if the method is called while the timeout is deleting the game?

— Reply to this email directly, view it on GitHub https://github.com/PiervitoCreanza/IS24-AM02/pull/139#discussion_r1633287563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA64MJYP4NMMUIDXC4WSY4TZGWVGVAVCNFSM6AAAAABIIB5KO2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBXHA3DKNBXGY. You are receiving this because you are subscribed to this thread.

ing. Conti G. Enrico @.*** Ordine Ingegneri di Monza al n. A894 Certing MBB-2430-IT20

PIVA 02119300966
C.FISC. CNTGNR63A23M052W via Duca degli Abruzzi 29 20900 MONZA MB ITALY 0039-039-324723 www.ingconti.com Pec: @.***

CODICE DESTINATARIO KRRH6B9

ingconti commented 4 months ago

;)

[PastedGraphic-1.png]

Ing. Gian Enrico Conti Ordine Ingegneri di Monza al n. A894

@. @.

webEx: https://politecnicomilano.webex.com/meet/gianenrico.conti

"This is my rifle. There are many others like it, but this one is mine. My rifle is my best friend. It is my life. I must master it as I must master my life. Without me, my rifle is useless. Without my rifle, I am useless. I must fire my rifle” PLS replace rifle with IDE.