PiervitoCreanza / IS24-AM02

This project is a Java-based implementation of the table game "Codex Naturalis", developed as the final project for the 2023/2024 Software Engineering course at Politecnico di Milano.
4 stars 0 forks source link

[GUI] Wrong overlapping of cards #173

Closed simonecurci closed 4 months ago

simonecurci commented 4 months ago

The board on the gui: Screenshot 2024-06-23 193809 The board on the tui: Screenshot 2024-06-23 194026 As you can see some cards aren't overlapping correctly.

mattiacolombomc commented 4 months ago

As the TUI PlayerBoard is generated starting from Model data, I think the GUI handles overlapping wrongly in some cases, maybe just with some types of cards?

ingconti commented 4 months ago

  as we discussed in many other occasions, make a fake method that will inject every, say, two seconds some new cardrs from network, or locally, in a a well known order of generation, so you can verify easily what happens to cars displayedSent from leakhunter iPhonewww.ingconti.comOn 23 Jun 2024, at 20:41, mattiacolombomc @.***> wrote: As the TUI PlayerBoard is generated starting from Model data, I think the GUI handles overlapping wrongly in some cases, maybe just with some types of cards?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

mattiacolombomc commented 4 months ago

Wrong rendering is due to local card placing

CleanShot 2024-06-24 at 11 01 14@2x CleanShot 2024-06-24 at 11 01 38@2x

PiervitoCreanza commented 4 months ago

Shoud be fixed now

mattiacolombomc commented 4 months ago

CleanShot 2024-06-24 at 13 08 31@2x CleanShot 2024-06-24 at 13 09 38@2x

Fixed! Great job!

ingconti commented 4 months ago

Wrong rendering is due to local card placing

CleanShot 2024-06-24 at 11 01 14@2x CleanShot 2024-06-24 at 11 01 38@2x

maybe you tried to optimise: send all the times for scratch removes a lot of pains....