search

PilzDE / pilz_application_templates

ROS application templates and example applications for pilz products.
Apache License 2.0
4 stars 4 forks source link

Fix naming of this repo #10

Closed agutenkunst closed 4 years ago

agutenkunst commented 4 years ago

This repo name indicates some sort of company templates and the naming does not indicate that it is only a template for prbt_applications. However if a company member creates a new repo the template drop_down only shows the title, which can be misleading and mistaken for a general ROS package template for Pilz packages.

Discovered by @oibrocevic :wink:

jschleicher commented 4 years ago

Imho this repo could serve for templates of different types. Especially not only including a manipulator but also sensors (like camera or lidar). So this was on purpose and I don't like to change it just because prbt_default_application is the only package yet. Please add more templates and split, if the number of packages gets too large...

agutenkunst commented 4 years ago

So I witnessed that the following view was missleading:

Screenshot from 2020-02-06 19-31-36

one could (and did) think that this would mean starting a new pilz package (e.g. integrate a new sensor) rather than a basis for applications. On the shown view nothing states "application"

jschleicher commented 4 years ago

So what about pilz_application_templates?

agutenkunst commented 4 years ago

Sounds good!

I suggested the following change to GH:

suggestion

jschleicher commented 4 years ago

So what about pilz_application_templates?

@JonathanGruner @PilzES Do you see any problems with existing applications? Would you agree changing the name?

JonathanGruner commented 4 years ago

@jschleicher I dont see any problems, because pilz_templates was used as template and the application itself has an other name anyway. But the name suggest that there will be more different templates, so I would prefer that there would be more applications if it where available. (PSEN-Scan, egp40, including cam, agv....)

Edit: @agutenkunst wrote:

This repo name indicates some sort of company templates and the naming does not indicate that it is only a template for prbt_applications.

Than change the name to prbt_application_templates or pilz_ros_application_templates, there are templates for other products too (Pss4000, PNOZ, Safety Eye..)

jschleicher commented 4 years ago

renamed and changed description.

agutenkunst commented 4 years ago

Thank you!