search

Pilzinsel64 / PlayerTags

A Dalamud plugin for Lightweight job visibility in nameplates and chat. Create custom tags and add them to players with the context menu.
MIT License
5 stars 5 forks source link

Inconsistent behavior between self and others #6

Closed athuy closed 1 year ago

athuy commented 1 year ago

When in a duty, the party number / alliance letter indicator is inconsistent between tags applied to self and other players: Other members seem to have the indicator as considered a part of their name, while the actual user has it considered separate.

See the image below for an example. image

Pilzinsel64 commented 1 year ago

Yesterday I investigated about two hours of debugging and testing to the more or less(?) experimental code to see what is going on. The result: As soon as I get the number with the name at the self linking feature, it doesn't get prepaired at the default chat feature for some reason.

Sadly I had no more time to go deeper. Because I always need someone that get with me together and sit there. Probably I'll do that spontanusly, or someone have more time and make a Pull Request with the fix. :)

Pilzinsel64 commented 1 year ago

Did some more testings. Fixing the issue on the side of the self linking feature is impossible since you can't create a PlayerPayload that works like you need and for other players. The game does very weird and different things for your own characters name, don't matter if in chat or on the nameplate.

Fixing in the other direction (moving the number to the left position for all group and alliance members) would be possible somehow but is huge of dirty work.

If someone has the time, feel free to fix that. Also that the last char of a group or allaince member name doesn't count to the player name anymore.

Pilzinsel64 commented 1 year ago

Fixed in v1.6.7