Unknown monomers are stripped without warning

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.

MIT License

19 stars 10 forks source link

Unknown monomers are stripped without warning #110

Closed ClairePA closed 7 years ago

ClairePA commented 7 years ago

Steps:

Type a

HELM string into the HELM box which contains monomers not present in the current monomer list
Click 'apply'
The HELM string is modified to remove the unknown monomers and the structure displayed simply misses them out.

The user should be warned that there are unknown monomers and informed about the action that will be taken.

scilligence commented 7 years ago

Could you give one example HELM string?

ClairePA commented 7 years ago

RNA1{moe[sp].moe[sp].moe[sp].moe[sp].moe[sp].dr[sp].dr[sp].dr[sp].dr[sp].dr[sp].dr[sp].dr[sp].dr[sp].dr[sp].dr[sp].moe[sp].moe[sp].moe[sp].moe[sp].moe[sp]}$$$$

scilligence commented 7 years ago

fixed 2017-05-21s

ClairePA commented 7 years ago

Now it displays an error message stating that there is an unknown monomer "o". There was no monomer "o" in the HELM string, so this is incorrect.

Also, the functionality to strip the monomer was useful behaviour, as you still got the rest of the molecule imported. Please reinstate this and make the error message state exactly which monomers have been removed, preferably in a single box so the user does not have to click through multiple error boxes.

ClairePA commented 7 years ago

Confirmed fixed.