search

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
20 stars 10 forks source link

You should not be able to enter a % in the ratio box #121

Closed ClairePA closed 6 years ago

ClairePA commented 7 years ago

Ratios for groups must be specified using numbers only. the % character or other non-numeric characters should not be permitted.

ClairePA commented 7 years ago

Validation is now implemented for ambiguous bonds.

It still needs to be added for unconnected groups.

scilligence commented 6 years ago

Fixed in 2017-11-13

ClairePA commented 6 years ago

It now checks whether the entry is a number, but does not prevent something else being entered.

image

image

scilligence commented 6 years ago

I am not sure how "g" is entered here. Could you write down the steps to reproduce?

ClairePA commented 6 years ago
  1. create peptide.
  2. create group.
  3. right click on group and select set attributes.
  4. type g into ratio box and click save.
  5. OK the error message stating that a number is required.
  6. The g is displayed on the group as shown in the picture above.

The validation is being done as the error is displayed, however the incorrect entry should not be accepted and displayed.

scilligence commented 6 years ago

It looks like this happens only in Edge

scilligence commented 6 years ago

Fixed in 2017-12-1 update

ClairePA commented 6 years ago

Confirmed fixed. Thanks.