PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
20 stars 10 forks source link

Search in monomers returns only monomer starting with search entry #124

Closed ypotier closed 6 years ago

ypotier commented 7 years ago

If I am searching 'biotin' in the search field of the monomer manager, I am expecting to have all the Biotin from CHEM returned but I see only one returned (Biotin TEG (Glen BiotinTEG Phosphoramidite 10-1955). I also tried to use the * symbol but it did not help.

I think we fixed that issue previously but the search in the monomer manager should return all monomer matching the user entry.

scilligence commented 7 years ago

Markus, could you check this? This is about the server side.

MarkusWeisser commented 7 years ago

We specified the filter criteria for searching within the symbol not the name. In addition, the search term should match the beginning of the symbol.

ypotier commented 7 years ago

Right, this part is working, but I expect the search to behave this way in the main canvas when searching for monomers. However, in the monomer search, I think it is unrealistic to expect user to know the monomer symbol when searching for monomers. My example of biotin still stands: users are looking for the different biotin available and cannot find them. Is it complicated to have the search point to the monomer name AND symbol rather than just symbol?

scilligence commented 7 years ago

Fixed in 2017-10-24 update: if a user type a string more than 2 letters, it will filter names as well. If just one letter or two, it will filter only symbols.

ypotier commented 7 years ago

@MarkusWeisser , after our conversation today during the meeting. Should we assign the ticket to you or close this one and follow the enhancements independently of the editor?

ClairePA commented 7 years ago

Action: Markus to create two backend services: one to perform a ‘contains’ search on symbol and one to perform a ‘contains’ search on name. Markus to let Tony know when this is done.

Action: Tony to create two separate fields from the symbol/name box and call the services Markus writes.

MarkusWeisser commented 7 years ago

New version on https://github.com/QuattroResearch/HELMMonomerService REST service for filtering monomers has new query parameter "filterField". Using "symbol" or "name" as query parameter will filter for these fields. If filterField is not specified, query will run for both fields (OR).

scilligence commented 7 years ago

(1) I grabbed the new war file there, and it looks like the Name filter doesn't work. Here is the URL I am using:

http://54.91.164.146/HELM2MonomerService/webService/service/library/monomer/ALL?limit=10&offset=0&filter=FAM&filterField=name&polymertype=&monomertype=&countperpage=

(2) If users fill both symbol and name filters, it looks like the code can do one.

MarkusWeisser commented 6 years ago

Running the war file on a local tomcat works on my machine with this URL with MongoDB: http://localhost:8080/HELM2MonomerService/webService/service/library/monomer/ALL?limit=10&offset=0&?monomertype=&filter=fam&filterField=name

Please check this on a local installation. Are you using MongoDB or SQLite?

scilligence commented 6 years ago

Updated in 2017-11-13

ClairePA commented 6 years ago

I can't get into the monomer manager at all. Clicking on the option does nothing.

scilligence commented 6 years ago

I am not sure what URL you used. Please start from this page: http://54.91.164.146/HELM2MonomerService/hwe/

ypotier commented 6 years ago

I used this URL and it worked for me, thank you.

ClairePA commented 6 years ago

Ah, I can get to the monomer manager from here: image

but not from here: image

The functionality works perfectly.

scilligence commented 6 years ago

It uses MongoDB now.

ClairePA commented 6 years ago

Great, but I can't get to the monomer manager from the webeditor.

scilligence commented 6 years ago

fixed in 2017-12-1 update

ClairePA commented 6 years ago

Confirmed fixed. Thanks.