Can't change the number on brackets on the canvas

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.

MIT License

20 stars 10 forks source link

Can't change the number on brackets on the canvas #126

Closed ClairePA closed 6 years ago

ClairePA commented 7 years ago

I can add brackets to a polymer and have a drop down box to add the number of recurrences as below:

The drop down does not contain anything. You add a number by typing, so either change to a text box or make it a true drop-down list.

Once a number has been added, it is not possible to change it.

scilligence commented 7 years ago

To change it, mouse-hover the number then press keyboard ENTER key.

ClairePA commented 7 years ago

OK, that works, but no one is going to remember how to do it. It should be possible to edit the numbers by clicking or double-clicking the brackets or number.

scilligence commented 6 years ago

Fixed in 2018-01-01 update: Use Right-click context menu

ClairePA commented 6 years ago

To be honest I think this is worse. You have to right-click the middle of the bracket whereas the intuitive place to click is the number itself. Also, it is not obvious what "set subscript" means. You should be able to click on the number and change it to something else without the need for a description at all.

scilligence commented 6 years ago

Could you suggest a solution? Sometime it has a number there, and sometime it might not have subscript at all.

ClairePA commented 6 years ago

I would like the following:

I draw a set of brackets and see this:

This is OK, but a text box would be better since the current box implies there is a drop down list, but no drop down list is available. It is not possible to define a list either, since ranges as well as single numbers are valid entries.

Once something has been added and I have clicked away I see this.

This is fine. There must be validation on the information entered, it must conform to one of the following patterns:

number or number-number or blank

I can highlight either the centre of the bracket by hovering near the middle of one bracket.

or the number at the bottom of the bracket by hovering there;

I would like to be able to click on the number and the text box reappear as it did when I originally drew the bracket.

I can then retype the values as I wish.

scilligence commented 6 years ago

Fixed in 2018-01-08 update. Now it is able to enter text edit mode by clicking on the number when it is bracket tool.

ClairePA commented 6 years ago

Confirmed fixed. Close.