PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
19 stars 10 forks source link

Brackets do not affect the molecule properties or structure view #128

Closed ClairePA closed 6 years ago

ClairePA commented 6 years ago

If I enter a structure and add brackets to indicate a repeating unit, the repeated unit information is not included in the structure display.

image

Or the structure properties -

image

scilligence commented 6 years ago

This means there are 4 terminal in this end, but there is one R1 availble to connect.

ClairePA commented 6 years ago

??? I don't understand the comment. Brackets should indicate a repeating unit i.e. the structure above should be AAAACG.

scilligence commented 6 years ago

In this picture above, it indicates there are 4 R(A)P- connecting to -R(C)P-. But -R(C)P- have only one R1 to be connected.

ClairePA commented 6 years ago

The picture above should not represent 4 R(A)P- connecting to -R(C)P- That particular set of brackets should mean R(A)P.R(A)P.R(A)P.R(A)P.R(C)P.R(C)P Your interpretation of the HELM rules is incorrect.

scilligence commented 6 years ago

fixed in 2017-10-30 update

ClairePA commented 6 years ago

Brackets now affect the properties, but not the structure view. image i.e. the same structure is show above and below. image

scilligence commented 6 years ago

Fix in 2017-11-20 update

ClairePA commented 6 years ago

Confirmed fixed. Thanks.