PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
19 stars 10 forks source link

Inconsistent nomenclature and use of the blob dialogue boxes #129

Closed ClairePA closed 6 years ago

ClairePA commented 6 years ago

If I right-click on a blob, I get a list of options for 'Blob type'

image If I choose 'Set Monomer Attributes' I can change the 'Monomer Type' or 'Annotation'

image

scilligence commented 6 years ago

fixed in 2017-10-31 update

ClairePA commented 6 years ago

I can see that it is not possible to change the monomer type now, but the rest still does not work. I think there is a misunderstanding over what each term means.

See the definition of blobs in the HELM specification:

Unknown Polymers are marked as BLOB type polymers. These polymers do not contain a list of monomers but they specify their type inside the curly braces. The polymer BLOB1{Bead} for example represents a polymer with the type “Bead”.

Also see an example of the HELM for a peptide sequence conjugated to a gold particle in the Line Notation Design document.

PEPTIDE1{C.C.C.C.C.C}|BLOB1{Gold Particle}”Au10, Diameter:10nm”$PEPTIDE,BLOB1,C:R3-?:R1$G1(PEPTIDE1:20-34+BLOB1)${“Name”:”Gold particle conjugated with peptides”,”Load”:26}$

Having a monomer type in the monomer attributes box makes little sense, as the user should simply remove the blob if they want a different type.

image

However they do need the ability to select a set of blob types from a drop down list and add an actual annotation.

scilligence commented 6 years ago

Fixed in 2017-11-06 update

scilligence commented 6 years ago

Fixed in 2017-11-06 update

ClairePA commented 6 years ago

I can still type in the monomer type box. I can't delete the blob text, but can make the value something that is not recognised. The monomer type section of this dialogue box should be removed as it is not needed. It won't be needed for any monomer as the monomer can be replace if the user wants to change it.

Also, the HELM is incorrect. image

In this case the HELM should be

BLOB1{Gold Particle}"rteyre"$$$$V2.0

scilligence commented 6 years ago

Fixed in 2017-11-07 update

ClairePA commented 6 years ago

Monomer type is still present. There is no such thing as monomer type. It is the symbol.

scilligence commented 6 years ago

Fixed 2017-11-13

ClairePA commented 6 years ago

Confirmed fixed. Thanks.